-
Notifications
You must be signed in to change notification settings - Fork 9
In-chart navigation with brush container #78
Conversation
@jotak this is a great feature! |
thanks @mtho11 ! |
How do you go back (zoom out)? |
At the moment, only by changing dates manually - this is not handled by the component itself. Or add zoom buttons similar to what we have on graph. Which also wouldn't be managed at this component level, it would be managed at the IstioMetrics / CustomMetrics level. Grafana does something similar: I think as a first step we can consider zooming out is done by explicit date selection, and we follow-up with next tasks improving UX |
Need a rebase, I am going to test this with the Jaeger integration but looks good @jotak nice :) |
@aljesusg yes I will rebase, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so LGFM I tested it in the storybook after rebase
Just a first try at the moment ; more improvements needed. Can be seen in storybook: ChartWithLegend / "as scatter with dates and in-chart navigation"
rebased |
It can be seen in storybook: ChartWithLegend / "as scatter with dates and in-chart navigation"
It allows to zoom-in charts.
Part of kiali/kiali#1860