Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

In-chart navigation with brush container #78

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Conversation

jotak
Copy link
Collaborator

@jotak jotak commented Feb 6, 2020

It can be seen in storybook: ChartWithLegend / "as scatter with dates and in-chart navigation"

Capture d’écran de 2020-02-06 15-56-16

It allows to zoom-in charts.

Part of kiali/kiali#1860

@mtho11
Copy link

mtho11 commented Feb 6, 2020

@jotak this is a great feature!

@jotak jotak marked this pull request as ready for review February 7, 2020 10:28
@jotak
Copy link
Collaborator Author

jotak commented Feb 7, 2020

thanks @mtho11 !

@israel-hdez
Copy link
Member

How do you go back (zoom out)?

@jotak
Copy link
Collaborator Author

jotak commented Feb 10, 2020

How do you go back (zoom out)?

At the moment, only by changing dates manually - this is not handled by the component itself.
Eventually we could consider using victory "zoom container" that allows zoom in/out with mouse wheel, but the problem is that it would conflict with page scrolling.

Or add zoom buttons similar to what we have on graph. Which also wouldn't be managed at this component level, it would be managed at the IstioMetrics / CustomMetrics level. Grafana does something similar:

Capture d’écran de 2020-02-10 09-24-35

I think as a first step we can consider zooming out is done by explicit date selection, and we follow-up with next tasks improving UX

@aljesusg
Copy link
Contributor

Need a rebase, I am going to test this with the Jaeger integration but looks good @jotak nice :)

@jotak
Copy link
Collaborator Author

jotak commented Feb 10, 2020

@aljesusg yes I will rebase,
but for the jaeger integration we will need to do this as a pre-requisite: kiali/kiali#2147
Because using this brush container means having custom time ranges, so it's necessary to do it as a first step.

Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so LGFM I tested it in the storybook after rebase

Just a first try at the moment ; more improvements needed.
Can be seen in storybook: ChartWithLegend / "as scatter with dates and in-chart navigation"
@jotak
Copy link
Collaborator Author

jotak commented Feb 10, 2020

rebased

@aljesusg aljesusg merged commit 34bdd94 into kiali:master Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants