Charts: click through tooltips #84
Conversation
When onclick handler is defined, it must catch clicks through tooltips as well. Else, tooltip would prevent user to catch what is "behind" it. Fixes kiali/kiali#2527
There was a problem hiding this comment.
Not sure if really important, but I see that if you click on the square that it's inside the tooltip, it won't trigger the event. Probably it would be tooooo much luck if that little square gets aligned with the chart's point and fall behind the mouse cursor to "block" the click. It's such a small area that it's probably like the change of a planetary alignment.
So... LGTM :D
| if (closest) { | ||
| this.props.onClick!(closest); | ||
| } | ||
| onClick!(event); |
There was a problem hiding this comment.
nitpicking... You probably don't need the bang.
There was a problem hiding this comment.
it's needed because we're in a lambda
Lol you're right :) . I believe it's so unlikely to happen (and so easily workable around, as clicking next to the square would still find closest point) that we can live without a fix for that Thanks for the review! |
When onclick handler is defined, it must catch clicks through tooltips as well. Else, tooltip would prevent user to catch what is "behind" it.
Fixes kiali/kiali#2527
Can be tested via storybook "ChartWithLegend as scatter plots", clicking on one of the plot where tooltip hides the plot: