Remove ComponentStatus from external_services (jaeger, grafana, prom) #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeviknal
added
the
requires server PR
hhovsepy
previously approved these changes
Nov 11, 2020
jmazzitelli
requested changes
Nov 11, 2020
There was a problem hiding this comment.
Looks like this is removing some settings that the null-cr-values-test molecule test is setting.
See: https://github.com/kiali/kiali-operator/blob/master/molecule/null-cr-values-test/kiali-cr.yaml#L72 (and other places). Just make sure that test CR is still valid.
jmazzitelli
reviewed
Nov 11, 2020
|
I've updated the molecule test for the nulls replacing the previous flag by the new one. |
jotak
reviewed
Nov 13, 2020
deploy/kiali/kiali_cr.yaml
Outdated
| # app_label: The value of the Grafana pod(s)'s app label. The name of the app label is defined in the setting 'istio_labels.app_label_name'. It defaults to grafana. | ||
| # is_core: Whether the component is core for your deployment. It defaults to false. | ||
| # namespace: The namespace where Grafana is installed in. It defaults to the 'istio_namespace' setting. | ||
| # core_component: Used in the Components health feature. When true, the unhealthy scenarios will be raised as errors. Otherwise, they will be raised as a warning. |
There was a problem hiding this comment.
I think I prefer with the is_ prefix to make it clear that a boolean is expected without having to refer to doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires kiali/kiali#3423
It remove the ComponentStatus from jaeger, prom and grafana. It leaves only one param for users tune the severity of the status in the masthead.