This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Tweak to the group compound layout algorithm #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove nodes from the parents instead of moving them outside
ghost
added this to the
jshaughn
pushed a commit
to jshaughn/kiali-ui
that referenced
this pull request
Oct 4, 2019
* Tweak to the group compound layout algorithm - Remove nodes from the parents instead of moving them outside * Makes bounds-expansion more stable by ommiting small diffs
jshaughn
added a commit
that referenced
this pull request
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation we (@josejulio , @jshaughn) found that two PR's created independently sort of clashed when run together, so it didn't emerge until after the merge.
First, in our GroupCompoundlayout, use elems.remove() as opposed to elems.move(). It's not clear why this is better, but it is. And do the remove/restore in one shot, for all parents.
The changes in the layout surfaced an issue in the new UX graph styling code, so that is part two of the fix.
The issues showed up in Chrome, but adversely affected FF even more, and Cola layout was the worst. Local testing on both browsers and all layouts now seem happy,
Fixes kiali/kiali#1764