This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhovsepy
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression tested for peerauthentications
@xeviknal worth to backport to 1.18 ? |
lucasponce
reviewed
May 25, 2020
@hhovsepy worth if the last changes on this one can be re-tested, as it affects to more pages. |
hhovsepy
approved these changes
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression tested.
xeviknal
force-pushed
the
fix-reference-link
branch
from
May 27, 2020 09:35
7213f16
to
7012391
Compare
xeviknal
force-pushed
the
fix-reference-link
branch
from
May 28, 2020 07:49
7012391
to
c23d76c
Compare
lucasponce
approved these changes
May 29, 2020
@lucasponce no need for backporting since it doesn't give much value to users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthorizationPolicy and ServiceMeshPolicy had a bad url definition.
The Istio Object list is using now same url than defined in the config file.