Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Validation reference link broken #1801

Merged
merged 3 commits into from
May 29, 2020
Merged

Conversation

xeviknal
Copy link
Member

@xeviknal xeviknal commented May 21, 2020

AuthorizationPolicy and ServiceMeshPolicy had a bad url definition.
The Istio Object list is using now same url than defined in the config file.

@xeviknal xeviknal self-assigned this May 21, 2020
@xeviknal xeviknal added this to In Review in Sprint 40 May 21, 2020
@xeviknal xeviknal requested a review from lucasponce May 21, 2020 08:54
@xeviknal xeviknal removed this from In Review in Sprint 40 May 21, 2020
@xeviknal xeviknal added this to In Review in Sprint 40 via automation May 21, 2020
@hhovsepy hhovsepy self-requested a review May 21, 2020 09:10
Copy link
Contributor

@hhovsepy hhovsepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tested for peerauthentications

@lucasponce
Copy link
Contributor

@xeviknal worth to backport to 1.18 ?

@lucasponce lucasponce requested a review from hhovsepy May 26, 2020 13:16
@lucasponce
Copy link
Contributor

@hhovsepy worth if the last changes on this one can be re-tested, as it affects to more pages.

Copy link
Contributor

@hhovsepy hhovsepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tested.

@lucasponce lucasponce merged commit 69f0775 into kiali:master May 29, 2020
Sprint 40 automation moved this from In Review to Done May 29, 2020
@ghost ghost added this to the v1.19.0 milestone May 29, 2020
@xeviknal xeviknal deleted the fix-reference-link branch May 29, 2020 13:03
@xeviknal
Copy link
Member Author

@lucasponce no need for backporting since it doesn't give much value to users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Sprint 40
  
Done
3 participants