This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Add Traces view to Service Details #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jotak
commented
Sep 2, 2020
jotak
force-pushed
the
service-traces
branch
from
64a5929
to
c13d480
Compare
Fixes kiali/kiali#3071 - Make class AppTracesC more generic, allowing app/service/workload input (and rename it: TracesComponent) - TracesFetcher now fetches different endpoints depending on target kind - "JaegerItemC" now receives a "focusElement" instead of app (and is renamed: TraceDetails) - Remove now unused cleanServiceSelector function - Define server endpoints API for fetching service/workload based traces - Add Traces tab to ServiceDetailsPage
jotak
force-pushed
the
service-traces
branch
from
c13d480
to
e7fa265
Compare
lucasponce
reviewed
Sep 4, 2020
| jaegerTraces: (namespace: string, app: string) => `api/namespaces/${namespace}/apps/${app}/traces`, | ||
| appTraces: (namespace: string, app: string) => `api/namespaces/${namespace}/apps/${app}/traces`, | ||
| serviceTraces: (namespace: string, svc: string) => `api/namespaces/${namespace}/services/${svc}/traces`, | ||
| workloadTraces: (namespace: string, wkd: string) => `api/namespaces/${namespace}/workloads/${wkd}/traces`, |
There was a problem hiding this comment.
I think this is not yet in the backend, isn't it ?
There was a problem hiding this comment.
yes I'm a bit ahead of time for this one ... first i thought i would do both tasks at the same time..
I can remove if you prefer, but anyway, I'll start to work on the workload case right after that one
lucasponce
reviewed
Sep 4, 2020
| return newRequest<JaegerResponse>(HTTP_VERBS.GET, urls.serviceTraces(namespace, service), params, {}); | ||
| }; | ||
|
|
||
| export const getWorkloadTraces = (namespace: string, workload: string, params: TracingQuery) => { |
There was a problem hiding this comment.
I think this is left here, this endpoint is not yet in the backend.
lucasponce
suggested changes
Sep 4, 2020
lucasponce
approved these changes
Sep 4, 2020
ghost
added this to the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kiali/kiali#3071
Backend PR: kiali/kiali#3169