KIALI-1000 Use blue border for selected nodes despite health #465
Conversation
|
@jotak a screenshot would be very beneficial here for "before/after" the change. |
|
@abonas I didn't put a screenshot because it's really as it was before the health addition: when selected, the node appears with the same blue border as before. (but i'll add a screenshot asap) |
|
@jotak having a description and associated screenshots will help. I think that you are saying that this PR just backs out reflecting health via node color. If that's the case 👍 |
|
Hmm not sure we're on the same page. The purpose of this PR is actually to NOT show the health color when a node is selected (of course, unselected nodes are still colored). See the JIRA ticket & discussions about it (since there were already some discussions there, if we want to revise the purpose of this PR then I'd suggest to do it on JIRA: https://issues.jboss.org/browse/KIALI-1000 Screenshots: productpage v1 node selected (degraded) Edge in error selected |
|
I'm +1 with this. However, I'm not convinced this is how it should ultimately be. I just don't know a good way to show health but still show what is selected. To me, it should be obvious what is selected (that's why I created the JIRA - it wasn't obvious what is selected) - I just don't know how to do that effectively :) |
|
@jmazzitelli yes I agree, too. This would not be the perfect solution, but perhaps a temporary step to align behaviour with how it works with edges, so we have some consistency. But either health or selection should have another distinctive way to be displayed that doesn't overlap with the other (could be line style (dotted/dashed/...) |
There was a problem hiding this comment.
LGTM as an intermediary solution. We might want to open up an issue for UXD on https://github.com/kiali/kiali-design for long-term.
CC: @serenamarie125
There was a problem hiding this comment.
LGTM 👍
@mtho11 please create an Issue with a description of what's needed from UX :)
No description provided.