Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Iter8 Experiment details page #2633

Closed
lucasponce opened this issue Apr 8, 2020 · 7 comments
Closed

Enhance Iter8 Experiment details page #2633

lucasponce opened this issue Apr 8, 2020 · 7 comments
Assignees

Comments

@lucasponce
Copy link
Contributor

Once we have a created an Iter8 experiment, Kiali offers a basic details page:

image

The goal of the issue is to discuss with @kiali/iter8 team how we want to engage this page:

  • What interesting info we want to add.
  • Do we want to add this info at Service Details levels too ? New tab, or some link to the Iter8 experiment details page (as it happens with Istio config).
  • Today we have implemented a basic create/delete actions. What actions make sense for an existing experiment ? Is a modification a valid scenarios or better to approach with a cancel/delete/new experiment flow ?

The idea is to first scope the feature itself (information to display, actions to perform, relationship with other entities).

When feature is almost defined, then we can involve UX team to help us to better design it in terms of usability.

I know it's an open topic, so, we are seeking a ready-action-pull-request to send, but to share ideas and iterate on prototypes on it.

@jadeyliu939
Copy link
Contributor

Prototype from the iter8 team on the experiment detail page. ( This is view only design, no actions yet)

Tab 1: Overview - contains detail information about the experiment, and a request volume chart.
The chart will show live view while the experiment is running. and once the experiment had ended, it will show a snapshot view with start/end time of the experiment as long there are prometheus data available.

- Live View
details-LiveView

-SnapShot View
detail-snapshot

Tab 2: Criteria

View - Collapsed
criteria

View - Expanded

criteria-expand

@lucasponce
Copy link
Contributor Author

@jadeyliu939 for this isssue I think it's ready.
I'm going to bring it to the UX meeting next Tuesday.
I will add you in the invitation via email.

@lucasponce
Copy link
Contributor Author

Hi @lwrigh @beaumorley

I'm planning to bring this one to our next Tuesday UX meeting
#2633

I will introduce @jadeyliu939 who is main developer on this.

Without enter in too many feature details, I guess from UX perspective we can start reviewing @jadeyliu939's proposal for mocks and check how they could be enhance.

I don't see any major blocker, but UX opinion should be great to help us.

cc @kiali/ux-reviewers

@lwrigh
Copy link

lwrigh commented Apr 16, 2020

@lucasponce That sounds good to me! We can gladly take a look at the proposal prior to the meeting. I'll leave any questions or comments that come to mind in the meantime.

@lucasponce
Copy link
Contributor Author

@lwrigh any update on this ?

I'm in favor to work in parallel, I mean @jadeyliu939 can work preparing a PR with her proposal, we can try to consolidate to resolve technically potential issues, and once we would have some UX recommendation we can apply them after, but in this case we can also offer users a first contact with this new feature.

This was referenced May 4, 2020
This was referenced May 12, 2020
lucasponce pushed a commit that referenced this issue May 14, 2020
* update experiment detail page and minor fix for create experiment

Issue #2633 - #2633
issue #2629 - #2629

* update Swagger validation error

* fix formatting

* more formatting error

* formtting fix

* Fix Build Error - missing Mock code

* Update mock.go

Co-authored-by: Yew-Huey Liu <yhliu@us.ibm.com>
lucasponce pushed a commit to kiali/kiali-ui that referenced this issue May 14, 2020
* update experiment detail page and minor fix for create experiment

For
Issue #2633 - kiali/kiali#2633
issue #2629 - kiali/kiali#2629

* Update ExperimentCriteriaForm.tsx

* defect: Create Button not enabled

* add missing css files

* fix build error

* Page Styling fixes

1. Remove the scss file, use inline style instead
2. Move back most of the styling changes in #2616, the one that I didn’t move back was due to the use of RenderHeader and ParameterizedTabs.
3. Put the action dropdown back for every tabs
4. Fix the expand button not changing when expand.

Co-authored-by: Yew-Huey Liu <yhliu@us.ibm.com>
@lucasponce
Copy link
Contributor Author

A couple of tasks that I'd like to plan for Sprint 46 are:

  • Integrate better Iter8 as a Wizard Action when Extension is detected (with more context brought from the service/details).
  • Possibly (to be discussed) to Introduce a simple Iter8 tab under linked service/workload.
  • Correlate Iter8 results in the details.

@lucasponce
Copy link
Contributor Author

@jadeyliu939 I'm going to close this one and perhaps detail in the main EPIC the next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants