-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some graph settings do not have query parms - can't bookmark pages #3840
Comments
This is true, I'm just not sure what the priority is to add all of the options. Waiting to add to backlog for some upvotes. |
I think this should be in the backlog. |
This comment is to just make explicit which graph options are and are not bookmarkable:
The understanding is that all graph options should support bookmarking, if reasonably feasible. |
- shorten URLs by not setting query params to defaults when unnecessary. It's not necessary for anything reset in the graph page constructor (i.e. unshared settings). kiali/kiali#3840
Support full graph bookmarking - add bookmarking for remaining Display options - add bookmarking for graph Find and Hide expressions - add bookmarking for replay - simplify by moving replayWindow from redux to class state - fix existing bug to maintain custom start time when changing replay length - note: replay bookmarking will not retain the frame, this is by design. I think the expected behavior would be to start the replay from the beginning, as it is always possible to have set a different start time. - fix existing datepicker issue when changing both day and time - fix existing bug in graph refresh after closing replay window - unrelated: update WorkloadPodLogs after noticing it wasn't using the "ReduxProps" convention. kiali/kiali#3840
Some settings in the graph do not have corresponding query params - so there is no way to, for example, bookmark a graph page that displays the cluster boxes (several of the display options are like this - cluster boxes is just an example).
The text was updated successfully, but these errors were encountered: