Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some graph settings do not have query parms - can't bookmark pages #3840

Closed
jmazzitelli opened this issue Apr 1, 2021 · 3 comments · Fixed by kiali/kiali-ui#2225
Closed
Assignees
Labels
backlog Triaged Issue added to backlog bug Something isn't working

Comments

@jmazzitelli
Copy link
Collaborator

Some settings in the graph do not have corresponding query params - so there is no way to, for example, bookmark a graph page that displays the cluster boxes (several of the display options are like this - cluster boxes is just an example).

@jmazzitelli jmazzitelli added the bug Something isn't working label Apr 1, 2021
@jshaughn
Copy link
Collaborator

This is true, I'm just not sure what the priority is to add all of the options. Waiting to add to backlog for some upvotes.

@lucasponce
Copy link
Contributor

I think this should be in the backlog.
In a separated issue there is a discussion to share the Graph view #3727 (comment), it's not directly related, but having a valid URL with support for all parameters will help in any case.

@lucasponce lucasponce added the backlog Triaged Issue added to backlog label Aug 10, 2021
@lucasponce lucasponce changed the title some graph settings do not have query parms - can't bookmark pages Some graph settings do not have query parms - can't bookmark pages Aug 10, 2021
@jshaughn jshaughn self-assigned this Aug 23, 2021
@jshaughn
Copy link
Collaborator

This comment is to just make explicit which graph options are and are not bookmarkable:

option supports bookmarking
duration yes
edge labels yes
graphType yes
layout yes
namespaces yes
refresh period yes
replay no
show idle edges yes
show idle nodes yes
show operation nodes yes
show service nodes yes
traffic rates yes
find/hide expr no
show animation no
show cluster box no
show badge security no
show badge sidecar no
show badge vs no
show namespace box no

The understanding is that all graph options should support bookmarking, if reasonably feasible.

jshaughn added a commit to jshaughn/kiali-ui that referenced this issue Aug 23, 2021
- shorten URLs by not setting query params to defaults when unnecessary. It's
  not necessary for anything reset in the graph page constructor (i.e. unshared
  settings).

kiali/kiali#3840
jshaughn added a commit to kiali/kiali-ui that referenced this issue Aug 30, 2021
Support full graph bookmarking
- add bookmarking for remaining Display options
- add bookmarking for graph Find and Hide expressions
- add bookmarking for replay
  - simplify by moving replayWindow from redux to class state
  - fix existing bug to maintain custom start time when changing replay length
  - note: replay bookmarking will not retain the frame, this is by design. I
     think the expected behavior would be to start the replay from the beginning,
     as it is always possible to have set a different start time.
  - fix existing datepicker issue when changing both day and time
- fix existing bug in graph refresh after closing replay window
- unrelated: update WorkloadPodLogs after noticing it wasn't using the "ReduxProps" convention.

kiali/kiali#3840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants