Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove istio_component_namespaces config #4109

Closed
jmazzitelli opened this issue Jun 17, 2021 · 2 comments · Fixed by kiali/kiali-operator#332, #4110 or kiali/kiali-ui#2180
Closed

remove istio_component_namespaces config #4109

jmazzitelli opened this issue Jun 17, 2021 · 2 comments · Fixed by kiali/kiali-operator#332, #4110 or kiali/kiali-ui#2180
Labels
enhancement This is the preferred way to describe new end-to-end features. requires operator PR It requires update in operator code requires UI PR A PR sent to the backend kiali/kiali requires changes on frontend kiali/kiali-ui
Projects
Sprint 58 (v1.36)

Comments

@jmazzitelli
Copy link
Collaborator

jmazzitelli commented Jun 17, 2021 •
edited
Loading

There was once a need for the istio_component_namespaces setting but that need has long since gone. This setting confuses people and isn't even used (doesn't work) when using the server helm chart.

And we do not mention it anywhere in our kiali.io docs (only mentioned in that kiali_cr.yaml example as linked above).

We should remove it.

PRs:

doesn't appear this config was used in the helm charts (which was part of the confusion :) so no PRs for helm repo needed.
@jmazzitelli jmazzitelli added enhancement This is the preferred way to describe new end-to-end features. area/installation+configuration requires operator PR It requires update in operator code requires helm chart PR labels Jun 17, 2021
@jmazzitelli jmazzitelli added this to Backlog in Sprint 58 (v1.36) via automation Jun 17, 2021
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Jun 17, 2021
@jmazzitelli
remove istio_component_namespaces config
c1e8016 
fixes: kiali/kiali#4109
@jmazzitelli jmazzitelli mentioned this issue Jun 17, 2021
Merged
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Jun 17, 2021
@jmazzitelli
remove istio_component_namespaces
538efb4 
fixes: kiali#4109
@jmazzitelli jmazzitelli mentioned this issue Jun 17, 2021
Merged
@jmazzitelli jmazzitelli added the requires UI PR A PR sent to the backend kiali/kiali requires changes on frontend kiali/kiali-ui label Jun 17, 2021
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Jun 17, 2021
@jmazzitelli
remove istio_component_namespaces
bb08bdd 
fixes: kiali#4109
jmazzitelli added a commit to jmazzitelli/kiali-ui that referenced this issue Jun 17, 2021
@jmazzitelli
remove istio_component_namespaces config
02b88a4 
fixes: kiali/kiali#4109
@jmazzitelli jmazzitelli mentioned this issue Jun 17, 2021
Merged
jmazzitelli added a commit to jmazzitelli/kiali that referenced this issue Jun 17, 2021
@jmazzitelli
remove istio_component_namespaces
aeaf807 
fixes: kiali#4109
@jmazzitelli
Copy link
Collaborator Author

@xeviknal can you review the three PRs for this issue? @jshaughn seemed to think you might know of a reason why we shouldn't remove this old config setting. Please review and comment on the PRs. Thanks.

@xeviknal
Copy link
Member

@jmazzitelli I thought @jshaughn needed this config for some reason. Thanks for breaking this eternal loop of confusion and bring peace to community.

Sprint 58 (v1.36) automation moved this from Backlog to Done Jun 18, 2021
jmazzitelli added a commit to kiali/kiali-operator that referenced this issue Jun 18, 2021
@jmazzitelli
remove istio_component_namespaces config (#332)
5b07214 
fixes: kiali/kiali#4109
jmazzitelli added a commit that referenced this issue Jun 18, 2021
@jmazzitelli
remove istio_component_namespaces config (#4110)
48c624a 
* remove istio_component_namespaces
fixes: #4109

* go format fixes this files, too

* fix linter error
jmazzitelli added a commit to kiali/kiali-ui that referenced this issue Jun 18, 2021
@jmazzitelli
remove istio_component_namespaces config (#2180)
f15873f 
fixes: kiali/kiali#4109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This is the preferred way to describe new end-to-end features. requires operator PR It requires update in operator code requires UI PR A PR sent to the backend kiali/kiali requires changes on frontend kiali/kiali-ui
Projects
No open projects
Sprint 58 (v1.36)
  
Done
Milestone
No milestone
2 participants
@xeviknal @jmazzitelli