Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove istio_component_namespaces config #332

Merged
merged 1 commit into from
Jun 18, 2021
Merged

remove istio_component_namespaces config #332

merged 1 commit into from
Jun 18, 2021

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli added requires server PR A PR requires additional changes in the backend code. team/saturn labels Jun 17, 2021
@jmazzitelli jmazzitelli self-assigned this Jun 17, 2021
@jmazzitelli jmazzitelli added this to In Review in Sprint 58 (v1.36) via automation Jun 17, 2021
@jmazzitelli jmazzitelli marked this pull request as ready for review June 17, 2021 19:28
@jmazzitelli jmazzitelli mentioned this pull request Jun 17, 2021
Closed
xeviknal
xeviknal approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@xeviknal xeviknal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazzitelli jmazzitelli merged commit 5b07214 into kiali:master Jun 18, 2021
Sprint 58 (v1.36) automation moved this from In Review to Done Jun 18, 2021
@jmazzitelli jmazzitelli deleted the remove-component-namespaces-4109 branch June 18, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeviknal xeviknal xeviknal approved these changes

@jshaughn jshaughn Awaiting requested review from jshaughn

Assignees

@jmazzitelli jmazzitelli

Labels
requires server PR A PR requires additional changes in the backend code.
Projects
No open projects
Sprint 58 (v1.36)
  
Done
Milestone
No milestone
2 participants
@jmazzitelli @xeviknal