Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in graph appender due to excluded namespace #6084

Closed
jshaughn opened this issue Apr 29, 2023 · 0 comments · Fixed by #6085
Closed

Crash in graph appender due to excluded namespace #6084

jshaughn opened this issue Apr 29, 2023 · 0 comments · Fixed by #6085
Assignees
@jshaughn
Labels
backlog Triaged Issue added to backlog blocker A bug breaks a fundamental feature. It's critical and it can't be workaround it. bug Something isn't working

Comments

@jshaughn
Copy link
Collaborator

There is an occasional crash occuring in Kiali's graph generation. The stack will show something like:

"error":"Namespace [kube-system] is excluded for Kiali",
"detail":"goroutine 631588 [running]:
runtime/debug.Stack()
  /home/jshaughn/App/go/src/runtime/debug/stack.go:24 +0x65
github.com/kiali/kiali/handlers.handlePanic({0x209edc0, 0xc0022fa330})
  /home/jshaughn/go/src/github.com/kiali/kiali/handlers/graph.go:86 +0x219
panic({0x19fe3c0, 0xc00286b9e0})
  /home/jshaughn/App/go/src/runtime/panic.go:884 +0x212
github.com/kiali/kiali/graph.CheckError(...)
  /home/jshaughn/go/src/github.com/kiali/kiali/graph/util.go:38
github.com/kiali/kiali/graph/telemetry/istio/appender.ServiceEntryAppender.getServiceEntry({0xc0019ca5a0?, {0xc0018b2e20?, 0x1dc6139?}}, {0xc0018b2dd4, 0xd}, {0xc001540ec9, 0x7}, 0xc00209ab00)
  /home/jshaughn/go/src/github.com/kiali/kiali/graph/telemetry/istio/appender/service_entry.go:173 +0xefb
github.com/kiali/kiali/graph/telemetry/istio/appender.ServiceEntryAppender.applyServiceEntries({0xc0019ca5a0?, {0xc0018b2e20?, 0xc000550d30?}}, 0x40d927?, 0xc00209ab00, 0xc0003ce2a0)
  /home/jshaughn/go/src/github.com/kiali/kiali/graph/telemetry/istio/appender/service_entry.go:94 +0x1e5
github.com/kiali/kiali/graph/telemetry/istio/appender.ServiceEntryAppender.AppendGraph({0xc0019ca5a0?, {0xc0018b2e20?, 0xc001a28e10?}}, 0xc0019cab40?, 0xc00209ab00?, 0xc001210390?)
  /home/jshaughn/go/src/github.com/kiali/kiali/graph/telemetry/istio/appender/service_entry.go:73 +0x117
github.com/kiali/kiali/graph/telemetry/istio.BuildNodeTrafficMap({0xc0019ca5a0, {0x0, {0xc000099980, 0x6, 0x6}}, 0x0, 0x1, 0xc0019ca4e0, {{0x1dbc7c8, 0x8}, ...}, ...},

The root cause is likely not the graph generation but rather namespace management; I think the issue could happen in other places as well.
@jshaughn jshaughn added bug Something isn't working blocker A bug breaks a fundamental feature. It's critical and it can't be workaround it. backlog Triaged Issue added to backlog labels Apr 29, 2023
@jshaughn jshaughn self-assigned this Apr 29, 2023
jshaughn added a commit to jshaughn/kiali that referenced this issue Apr 29, 2023
@jshaughn
Prevent scenario where a token's namespaces cache can be set to the
0ae55e9 
unfiltered namespaces for a single cluster.

kiali#6084
@jshaughn jshaughn mentioned this issue Apr 29, 2023
Merged
jshaughn added a commit that referenced this issue May 2, 2023
@jshaughn
Prevent bad namespaces cache scenario (#6085)
8d08235 
Prevent scenario where a token's namespaces cache can be set to the unfiltered namespaces for a single cluster.

#6084
jshaughn added a commit to jshaughn/kiali that referenced this issue May 3, 2023
@jshaughn
Prevent bad namespaces cache scenario (kiali#6085)
860c77a 
Prevent scenario where a token's namespaces cache can be set to the unfiltered namespaces for a single cluster.

kiali#6084
# Conflicts:
#	handlers/istio_config.go
@jshaughn jshaughn mentioned this issue May 3, 2023
Merged
jshaughn added a commit that referenced this issue May 3, 2023
@jshaughn
Prevent bad namespaces cache scenario (#6085) (#6095)
f0e0cef 
Prevent scenario where a token's namespaces cache can be set to the unfiltered namespaces for a single cluster.

#6084
# Conflicts:
#	handlers/istio_config.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshaughn jshaughn

Labels
backlog Triaged Issue added to backlog blocker A bug breaks a fundamental feature. It's critical and it can't be workaround it. bug Something isn't working
Projects
Kiali Sprint 24-12 | Kiali v1.89.x
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent crash scenario in namespace management jshaughn/kiali
1 participant
@jshaughn