-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace iframes with wrappers #168
Conversation
If the kialiUrl is getting removed, then this issue can be closed since it involves the kialiUrl setting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we know for sure we will never need configurability in the plugin, I suggest we leave the ConfigMap/config file in place - even if it is empty right now. That way we don't have to repeat work that was already done in the future if we need to add a config option.
operator work to remove kiali.url is done here: ferhoyos#4 |
now that the new frontend code is in master, I can't build this PR to test it... lots of errors about default exports. So I'll wait for updates to this PR before testing example of error (there are many like this):
|
5e5558f
to
9172e96
Compare
Compilation errors are fixed. @jmazzitelli you can test PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test via make cluster-push operator-create install-cr
and I see the native graph page now.
BTW... @ferhoyos while looking up how to install this via make, I noticed this in the README that is incorrect : |
Closes #160
Testing PR:
OSSM Console plugin in Openshift should behave the same way as with iframes. If you install the plugin via operator takes into account cluster param issue (kiali/kiali#6322).
IstioConfigListPage has been refactored and now it shows Validation summary as in Kiali and namespace reference link:
Note: To make it work I have modified 3 files of Kiali application. This will be addressed in kiali/kiali#6266 to avoid these modifications in the future.