Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iframes with wrappers #168

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Jun 27, 2023

Closes #160

Testing PR:
OSSM Console plugin in Openshift should behave the same way as with iframes. If you install the plugin via operator takes into account cluster param issue (kiali/kiali#6322).

IstioConfigListPage has been refactored and now it shows Validation summary as in Kiali and namespace reference link:

image

Note: To make it work I have modified 3 files of Kiali application. This will be addressed in kiali/kiali#6266 to avoid these modifications in the future.

@ferhoyos ferhoyos self-assigned this Jun 27, 2023
@jmazzitelli
Copy link
Contributor

If the kialiUrl is getting removed, then this issue can be closed since it involves the kialiUrl setting:

Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we know for sure we will never need configurability in the plugin, I suggest we leave the ConfigMap/config file in place - even if it is empty right now. That way we don't have to repeat work that was already done in the future if we need to add a config option.

plugin/plugin-config.json Show resolved Hide resolved
README.md Show resolved Hide resolved
make/Makefile.plugin.mk Show resolved Hide resolved
plugin/manifest.yaml Outdated Show resolved Hide resolved
@jmazzitelli
Copy link
Contributor

operator work to remove kiali.url is done here: ferhoyos#4

@jmazzitelli
Copy link
Contributor

now that the new frontend code is in master, I can't build this PR to test it... lots of errors about default exports. So I'll wait for updates to this PR before testing

example of error (there are many like this):

ERROR in ./src/openshift/utils/Reducer.ts:16:8
TS1192: Module '"/home/jmazzite/source/kiali/openshift-servicemesh-plugin/plugin/src/kiali/reducers/MessageCenter"' has no default export.
    14 | import tour from 'reducers/TourState';
    15 | import namespaces from 'reducers/NamespaceState';
  > 16 | import Messages from 'reducers/MessageCenter';

@ferhoyos ferhoyos force-pushed the 160-replace-iframes-wrappers branch from 5e5558f to 9172e96 Compare July 3, 2023 09:11
@ferhoyos
Copy link
Collaborator Author

ferhoyos commented Jul 3, 2023

Compilation errors are fixed. @jmazzitelli you can test PR again.

Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test via make cluster-push operator-create install-cr and I see the native graph page now.

@jmazzitelli
Copy link
Contributor

jmazzitelli commented Jul 3, 2023

BTW... @ferhoyos while looking up how to install this via make, I noticed this in the README that is incorrect :

@ferhoyos ferhoyos merged commit fc59bbb into kiali:main Jul 3, 2023
3 checks passed
@ferhoyos ferhoyos deleted the 160-replace-iframes-wrappers branch July 3, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Replace iframes with wrappers
2 participants