Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb click on Istio Type filter - Filter type is reset #6632

Closed
hhovsepy opened this issue Sep 18, 2023 · 1 comment · Fixed by #6636
Closed

Breadcrumb click on Istio Type filter - Filter type is reset #6632

hhovsepy opened this issue Sep 18, 2023 · 1 comment · Fixed by #6636
Assignees
@jshaughn
Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working

Comments

@hhovsepy
Copy link
Contributor

Happen on Kiali master.

Go to any Istio config details page.
Click on Breadcrumb's Istio Config Type.
Should load Istio Configs filteret by particular type, but in fact filter is not set.
Also sorting by 'Type' field is not working.

This is because 'istiotype' param is used instead of 'type'.
@hhovsepy hhovsepy added bug Something isn't working backlog Triaged Issue added to backlog labels Sep 18, 2023
@jshaughn jshaughn self-assigned this Sep 18, 2023
@jshaughn
Copy link
Collaborator

Thanks for spotting this, @hhovsepy. Looks like I missed something in the recent PR around the type filtering.

jshaughn added a commit to jshaughn/kiali that referenced this issue Sep 18, 2023
@jshaughn
- Fix breadcrumb link issue for istio config type
8a3b9fb 
- Fix a sorting issue in VirtualList, when there are hidden columns

kiali#6632
@jshaughn jshaughn mentioned this issue Sep 18, 2023
Merged
hhovsepy pushed a commit that referenced this issue Sep 19, 2023
@jshaughn
- Fix breadcrumb link issue for istio config type (#6636)
ef3ee50 
- Fix a sorting issue in VirtualList, when there are hidden columns

#6632
jshaughn added a commit to jshaughn/kiali that referenced this issue Sep 20, 2023
@jshaughn
- Fix breadcrumb link issue for istio config type (kiali#6636)
7b18b41 
- Fix a sorting issue in VirtualList, when there are hidden columns

kiali#6632
@jshaughn jshaughn mentioned this issue Sep 20, 2023
Merged
jshaughn added a commit that referenced this issue Sep 21, 2023
@jshaughn
- Fix breadcrumb link issue for istio config type (#6636) (#6650)
ce6a9b2 
- Fix a sorting issue in VirtualList, when there are hidden columns

#6632
@jshaughn jshaughn added backport needed Issue PRs require backport to versions specified in comments backport completed Issue PRs have been backported labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshaughn jshaughn

Labels
backlog Triaged Issue added to backlog backport completed Issue PRs have been backported backport needed Issue PRs require backport to versions specified in comments bug Something isn't working
Projects
Kiali Sprint 24-5 | Kiali 1.84
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix breadcrumb link issue for istio config type jshaughn/kiali
2 participants
@hhovsepy @jshaughn