Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb link issue for istio config type #6636

Merged
merged 1 commit into from Sep 19, 2023

Conversation

jshaughn
Copy link
Collaborator

Fixes #6632

  • Fix breadcrumb link issue for istio config type
    • some cleanup: Fix type in type name, add some type safety, add some alphabetization, remove unnecessary vars
  • Fix a sorting issue in VirtualList, when there are hidden columns

- Fix a sorting issue in VirtualList, when there are hidden columns

kiali#6632
@jshaughn jshaughn self-assigned this Sep 18, 2023
Copy link
Contributor

@hhovsepy hhovsepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested locally, both issues are fixed

@hhovsepy hhovsepy merged commit ef3ee50 into kiali:master Sep 19, 2023
6 checks passed
jshaughn added a commit to jshaughn/kiali that referenced this pull request Sep 20, 2023
- Fix a sorting issue in VirtualList, when there are hidden columns

kiali#6632
jshaughn added a commit that referenced this pull request Sep 21, 2023
- Fix a sorting issue in VirtualList, when there are hidden columns

#6632
@matejnesuta matejnesuta added the test: n/a PR does not need test additions or updates label Nov 15, 2023
@jshaughn jshaughn deleted the kiali6632 branch February 12, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

Breadcrumb click on Istio Type filter - Filter type is reset
3 participants