to support system tests / code coverage #1032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e system tests/code coverage in Kiali
jmazzitelli
commented
Apr 23, 2019
| @@ -0,0 +1,25 @@ | |||
| #!/bin/bash | |||
|
|
|||
| bash <(curl -L https://git.io/getLatestKialiOperator) | |||
There was a problem hiding this comment.
Note that I just did this "curl" download simply to pick up the released version. This is simply running the stock operator/deploy/deploy-kiali-operator.sh script. You can execute that script however you do it normally - if you are running this out of a git cloned repo, you could make this something like ../../operator/deploy/deploy-kiali-operator.sh instead.
|
this isn't needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible replacement for PR #970
I have not run the Makefile target or the main_test.go defined here - I simply found them in PR #970 and assumed Jenkins somehow uses them.
But the .sh script I did run with and that did work (even though the pod logged an error because kiali didn't have the systemTests option compiled in it - which I assume is what main_test.go provides)
This is just an example PR. QE can take it and use it, alter it, duplicate it and change it.. whatever is best. I just created this as an example of how we can do this without injecting this systemTest test all throughout the operator.