Enable code coverage for system tests #970
Conversation
FilipB
force-pushed
the
system-tests-code-coverage
branch
from
bd45ae2
to
de63e1b
Compare
|
cc @gbaufake |
|
Do not merge, waiting for changes from #974 |
|
kialiqeci |
FilipB
force-pushed
the
system-tests-code-coverage
branch
2 times, most recently
from
7366e51
to
1c885f7
Compare
|
kialiqeci |
|
kialiqeci |
|
kialiqeci |
|
This is ready to be merged. @gbaufake @jmazzitelli could you please review? |
There was a problem hiding this comment.
we need to figure out a better way to do this. All of this just to inject code-coverage? Not only that, but community members don't even have access to our coverage tests - its all internal to our jenkins no? So they don't even get any benefit.
We need to figure out a better way to do this - extract this out of the user-facing pieces and put it into independent test components.
operator/roles/kiali-deploy/templates/openshift/deployment.yaml
Outdated
Show resolved
Hide resolved
|
See #1032 for my recommendation on how we should do something like this. |
This commit adds possibility to build kiali which can produce code coverage report even for system tests which run against kiali deployed in OpenShift. Note this does not do anything for code coverage of unit tests.
FilipB
force-pushed
the
system-tests-code-coverage
branch
from
1c885f7
to
892cfba
Compare
|
@jmazzitelli This PR now contains only minimal changes. I will keep deployment logic in our internal scripts. If we don't want to push anything related to code coverage of system tests to kiali repo that's fine too. I'm always building kiali from sources so I can include main_test.go file while building. In that case we can close this PR. |
ghost
added this to the 
** Describe the change **
This commit adds possibility to build kiali which can produce code coverage report even for system tests which run against kiali deployed in OpenShift. Note this does not do anything for code coverage of unit tests.