KIALI-2877 Remove outdated documentation in config.yaml #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in kiali#1059 (comment). Support for credentials in config.yaml was removed in PR kiali#883. So this looks safe to remove, since credentials in config.yaml are no longer honored.
jmazzitelli
approved these changes
May 17, 2019
|
FWIW: there is other things wrong with this file :) like the prometheus URL setting is wrong now. I'm not sure what else is. This is an obsolete file - i don't think anyone is using it or the make run target. If it is being used, someone should go through and confirm it all works. |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #1059 (comment).
Support for credentials in config.yaml was removed in PR #883. So this looks safe to remove, since credentials in config.yaml are no longer honored.