Adding MultiMatch and NoWorkloadFound validations to PeerAuthentication #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhovsepy
previously approved these changes
May 21, 2020
lucasponce
reviewed
May 25, 2020
| return s.HasWorkloadSelectorLabels() | ||
| } | ||
|
|
||
| func getLabels(first, second string, s kubernetes.IstioObject) map[string]string { |
There was a problem hiding this comment.
Minor one.
I have started to add more comments in the helpers methods in my PRs as well.
Basically for me, but also it helps others to get more clarity and reduce ambiguity what this helper was necessary.
If you can get a couple of comments about that "first, second" means, perhaps it helps reviewer to not enter in the implementation detail to get it.
|
@lucasponce comments approached. |
This was referenced May 28, 2020
lucasponce
approved these changes
May 29, 2020
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding MultiMatch and NoWorkloadFound validations to PeerAuthentication. Both validations has been moved to a common place just to better reuse the code. The validations are quite standard since the "workloadSelector" field is quite standard within Istio CRDs.
Related to #2086
Needs documentation PR: kiali/kiali.io#240
Yamls to reproduce errors: