KIALI-1326 Remove service nodes not showing error traffic #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This screenshot sequence shows the change:
|
|
@jmazzitelli , @mwringe , This is something I mentioned to Matt at the end of the day Friday when we were looking at his env. It isn't classified as a blocker since it was after the triage. I'm not opposed to it being included in the pre-release, though. |
|
The screenshots make sense. This looks good. I did not personally test this, but it looks like we can merge this into master. However, we should NOT merge this into pre-release. |
jmazzitelli
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For why this is needed see this Jira.