New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSSM-1216] cypress container #6029
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
302cb70
initial commit for cypress container
ScriptingShrimp 8c7b112
removin old fix for chrome
ScriptingShrimp c5484ba
cleanup and yarn --force
ScriptingShrimp 83c5d35
removing user
ScriptingShrimp 9bd8a41
OSSM-3670: updating cypress dockerfile to make it work on OCP
FilipB 68e7e84
copy also hack scripts which will be used to install demo apps
FilipB File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
_output | ||
operator | ||
deploy | ||
frontend/node_modules | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# don't forget to pass environmet variables to docker run like this: | ||
# podman run -e CYPRESS_BASE_URL=<kiali_url> -e CYPRESS_PASSWD=<passwd> docker-cypress:latest | ||
# more details here https://github.com/kiali/kiali/tree/master/frontend/cypress | ||
|
||
# using same baseimage of node as its defined in package.json | ||
FROM cypress/base:14.17.0 | ||
|
||
# we need to set HOME when running on OCP with random UID, otherwise the home is set to / and any writing there will fail with permission denied | ||
ENV HOME=/tmp/kiali | ||
|
||
# copy also hack scripts which will be used to install demo apps | ||
COPY hack $HOME/hack | ||
COPY frontend/ $HOME/ | ||
|
||
WORKDIR $HOME | ||
|
||
# Install Cypress dependencies. | ||
RUN yarn install --frozen-lockfile | ||
|
||
# Set required permissions for OpenShift usage | ||
RUN chgrp -R 0 $HOME && \ | ||
chmod -R g=u $HOME | ||
|
||
# Run Cypress tests. | ||
CMD ["yarn", "cypress:run:junit"] | ||
ScriptingShrimp marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will affect other Dockerfiles in this folder, is that safe @FilipB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be safe as other images are build using CONTEXT ${OUTDIR}/docker, e.g. https://github.com/kiali/kiali/blob/master/make/Makefile.container.mk#L17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand it precisely, but I believe you 😄