Correct Kubernetes versions for multi-primary scenarios #7370
Conversation
ferhoyos
changed the title
|
Currently the Istio version from remote cluster cannot be obtained because Istio settings are only supported for single-cluster (related to issue #7203). I think that for the moment we can fix only Kubernetes version and assume that remote Istio version is the same as home cluster one. |
There was a problem hiding this comment.
Tested on my single OCP 4.14 CRC cluster and working fine in that scenario. I'll leave the changes to version determination to Nick as I know you two were going back on forth on it. +1 to limiting to kube version. Also, the CI fails are all know flakes so no problem there. LGTM.
| @@ -65,6 +65,7 @@ | |||
| "Kiali home cluster": "Kiali home cluster", | |||
| "Kiali home cluster: {{name}}": "Kiali主集群: {{name}}", | |||
| "Kiali on GitHub": "Kiali on GitHub", | |||
| "Kubernetes": "Kubernetes", | |||
There was a problem hiding this comment.
I guess this maybe has a translation into other character sets? I don't know, not a problem to include it even if they leave it alone.
There was a problem hiding this comment.
I don't know, probably there is no translation. I just changed Version to Kubernetes and I did not care about the translation. Anyway, if that is the case we can remove it afterwards.
| {renderNodeHeader(clusterData, { nameOnly: true, smallSize: false, hideBadge: clusterData.isExternal })} | ||
| <div className={infoStyle}> | ||
| {!clusterData.isExternal && `${t('Version')}: ${clusterData.version || UNKNOWN}`} | ||
| {!clusterData.isExternal && `${t('Kubernetes')}: ${clusterData.version || UNKNOWN}`} |
| @@ -62,7 +65,7 @@ export const TargetPanelMesh: React.FC<TargetPanelMeshProps> = (props: TargetPan | |||
|
|
|||
| const renderInfraNodeSummary = (nodeData: MeshNodeData): React.ReactNode => { | |||
| return ( | |||
| <div className={summaryStyle}> | |||
| <div key={nodeData.id} className={summaryStyle}> | |||
|
Merging as CI failures are known flakes and @ferhoyos has said it is good to merge. |
Describe the change
This PR adds support for multi-primary scenarios, providing correct versions for Kubernetes in the mesh page.
Steps to test the PR
Automation testing
N/A
Issue reference
Fixes #7361