KIALI-2638 Add Handlers and Instances to IstioConfig #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this PR can be easily tested with Creating the deploy/ and istio/ resources from the project under the istio-system ns. |
|
Verified. After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Describe the change **
Update adapters/templates code to support old CRD way to install/configure adapters (with one CRD per item) or new way with generic "adapter"/"template"/"handler"/"instances" way.
Note, that Istio 1.1 maintains old way, in Istio 1.2 the old CRD will be removed and that will highly simplify the logic as no need to fetch specific CRD code.
** Issue reference **
https://issues.jboss.org/browse/KIALI-2638
** Backwards incompatible? **
Yes, this modifies clusterrole.yaml as usual an it needs updates in upstream and downstream.
cc @gbaufake @jmazzitelli
Note, this is a preliminar step towards 3scale integration, so now Kiali can proper list and edit external adapters code: