[ML] Add functional tests for Field stats flyout in Transforms & DFA …

…creation wizard (elastic#150927) (cherry picked from commit 7906c76)
kibanamachine · Feb 15, 2023 · 52f3218 · 52f3218
1 parent 071527e
commit 52f3218
Show file tree

Hide file tree

Showing 14 changed files with 496 additions and 24 deletions.
diff --git a/x-pack/plugins/ml/public/application/components/field_stats_flyout/field_stats_content.tsx b/x-pack/plugins/ml/public/application/components/field_stats_flyout/field_stats_content.tsx
@@ -62,7 +62,7 @@ export const FieldStatsContent: FC<{
       toDate={timeRange.to}
       dataViewOrDataViewId={currentDataView}
       field={fieldForStats}
-      data-test-subj={`jobCreatorFieldStatsPopover ${fieldForStats.name}`}
+      data-test-subj={`mlFieldStatsFlyoutContent ${fieldForStats.name}`}
       color={DEFAULT_COLOR}
     />
   ) : null;

diff --git a/x-pack/plugins/ml/public/application/components/field_stats_flyout/field_stats_flyout.tsx b/x-pack/plugins/ml/public/application/components/field_stats_flyout/field_stats_flyout.tsx
@@ -40,7 +40,13 @@ export const FieldStatsFlyout: FC<{
 
   if (isFlyoutVisible) {
     return (
-      <EuiFlyout type="push" size="xs" onClose={closeFlyout} aria-labelledby={pushedFlyoutTitleId}>
+      <EuiFlyout
+        type="push"
+        size="xs"
+        onClose={closeFlyout}
+        aria-labelledby={pushedFlyoutTitleId}
+        data-test-subj="mlFieldStatsFlyout"
+      >
         <EuiFlyoutHeader hasBorder>
           <EuiTitle size="m">
             <h3 id={pushedFlyoutTitleId}>

diff --git a/...k/plugins/ml/public/application/components/field_stats_flyout/field_stats_info_button.tsx b/...k/plugins/ml/public/application/components/field_stats_flyout/field_stats_info_button.tsx
@@ -36,6 +36,7 @@ export const FieldStatsInfoButton = ({
           )}
         >
           <EuiButtonIcon
+            data-test-subj={`mlInspectFieldStatsButton-${field.id}`}
             disabled={field.id === EVENT_RATE_FIELD_ID}
             size="xs"
             iconType="inspect"
@@ -56,7 +57,6 @@ export const FieldStatsInfoButton = ({
                 defaultMessage: 'Inspect field statistics',
               }
             )}
-            data-test-subj={'mlAggSelectFieldStatsPopoverButton'}
           />
         </EuiToolTip>
       </EuiFlexItem>

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts
@@ -5,8 +5,9 @@
  * 2.0.
  */
 
-import { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
-import { FtrProviderContext } from '../../../ftr_provider_context';
+import type { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
+import type { FtrProviderContext } from '../../../ftr_provider_context';
+import type { FieldStatsType } from './types';
 
 export default function ({ getService }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
@@ -16,7 +17,7 @@ export default function ({ getService }: FtrProviderContext) {
   describe('classification creation', function () {
     before(async () => {
       await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/bm_classification');
-      await ml.testResources.createIndexPatternIfNeeded('ft_bank_marketing', '@timestamp');
+      await ml.testResources.createIndexPatternIfNeeded('ft_bank_marketing');
       await ml.testResources.setKibanaTimeZoneToUTC();
 
       await ml.securityUI.loginAsMlPowerUser();
@@ -49,6 +50,18 @@ export default function ({ getService }: FtrProviderContext) {
         trainingPercent: 20,
         modelMemory: '60mb',
         createIndexPattern: true,
+        fieldStatsEntries: [
+          {
+            fieldName: 'age',
+            type: 'number' as FieldStatsType,
+            isDependentVariableInput: true,
+          },
+          {
+            fieldName: 'balance.keyword',
+            type: 'keyword' as FieldStatsType,
+            isDependentVariableInput: true,
+          },
+        ],
         expected: {
           rocCurveColorState: [
             // tick/grid/axis
@@ -138,8 +151,20 @@ export default function ({ getService }: FtrProviderContext) {
             testData.expected.runtimeFieldsEditorContent
           );
 
-          await ml.testExecution.logTestStep('inputs the dependent variable');
+          await ml.testExecution.logTestStep(
+            'opens field stats flyout from dependent variable input'
+          );
           await ml.dataFrameAnalyticsCreation.assertDependentVariableInputExists();
+          for (const { fieldName, type: fieldType } of testData.fieldStatsEntries.filter(
+            (e) => e.isDependentVariableInput
+          )) {
+            await ml.dataFrameAnalyticsCreation.assertFieldStatsFlyoutContentFromDependentVariableInputTrigger(
+              fieldName,
+              fieldType
+            );
+          }
+
+          await ml.testExecution.logTestStep('inputs the dependent variable');
           await ml.dataFrameAnalyticsCreation.selectDependentVariable(testData.dependentVariable);
 
           await ml.testExecution.logTestStep('inputs the training percent');

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts
@@ -5,8 +5,9 @@
  * 2.0.
  */
 
-import { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
-import { FtrProviderContext } from '../../../ftr_provider_context';
+import type { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
+import type { FtrProviderContext } from '../../../ftr_provider_context';
+import type { FieldStatsType } from './types';
 
 export default function ({ getService }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
@@ -38,6 +39,20 @@ export default function ({ getService }: FtrProviderContext) {
     });
 
     const dateNow = Date.now();
+    const fieldStatsEntries = [
+      {
+        fieldName: 'airline',
+        type: 'keyword' as FieldStatsType,
+        isDependentVariableInput: true,
+        isIncludeFieldInput: true,
+      },
+      {
+        fieldName: '@version',
+        type: 'keyword' as FieldStatsType,
+        isIncludeFieldInput: true,
+      },
+    ];
+
     const testDataList = [
       {
         suiteTitle: 'with lucene query',
@@ -48,6 +63,7 @@ export default function ({ getService }: FtrProviderContext) {
         get destinationIndex(): string {
           return `user-${this.jobId}`;
         },
+        fieldStatsEntries,
         runtimeFields: {
           uppercase_airline: {
             type: 'keyword',
@@ -59,6 +75,10 @@ export default function ({ getService }: FtrProviderContext) {
         modelMemory: '20mb',
         createIndexPattern: true,
         expected: {
+          fieldStatsValues: { airline: ['AAL', 'AWE', 'ASA', 'ACA', 'AMX'] } as Record<
+            string,
+            string[]
+          >,
           source: 'ft_farequote_small',
           rocCurveColorState: [
             // tick/grid/axis
@@ -99,6 +119,7 @@ export default function ({ getService }: FtrProviderContext) {
         get destinationIndex(): string {
           return `user-${this.jobId}`;
         },
+        fieldStatsEntries,
         runtimeFields: {
           uppercase_airline: {
             type: 'keyword',
@@ -110,6 +131,10 @@ export default function ({ getService }: FtrProviderContext) {
         modelMemory: '20mb',
         createIndexPattern: true,
         expected: {
+          fieldStatsValues: { airline: ['AAL', 'AWE', 'ASA', 'ACA', 'AMX'] } as Record<
+            string,
+            string[]
+          >,
           source: 'ft_farequote_small',
           rocCurveColorState: [
             // tick/grid/axis
@@ -150,6 +175,7 @@ export default function ({ getService }: FtrProviderContext) {
         get destinationIndex(): string {
           return `user-${this.jobId}`;
         },
+        fieldStatsEntries,
         runtimeFields: {
           uppercase_airline: {
             type: 'keyword',
@@ -161,6 +187,9 @@ export default function ({ getService }: FtrProviderContext) {
         modelMemory: '20mb',
         createIndexPattern: true,
         expected: {
+          fieldStatsValues: {
+            airline: ['AAL', 'ASA'],
+          } as Record<string, string[]>,
           source: 'ft_farequote_small',
           rocCurveColorState: [
             // tick/grid/axis
@@ -213,6 +242,7 @@ export default function ({ getService }: FtrProviderContext) {
         modelMemory: '20mb',
         createIndexPattern: true,
         expected: {
+          fieldStatsValues: { airline: ['ASA', 'FFT'] } as Record<string, string[]>,
           source: 'ft_farequote_small',
           rocCurveColorState: [
             // tick/grid/axis
@@ -293,9 +323,23 @@ export default function ({ getService }: FtrProviderContext) {
           await ml.dataFrameAnalyticsCreation.assertRuntimeMappingsEditorContent(
             testData.expected.runtimeFieldsEditorContent
           );
+          await ml.testExecution.logTestStep(
+            'opens field stats flyout from dependent variable input'
+          );
+          await ml.dataFrameAnalyticsCreation.assertDependentVariableInputExists();
+          for (const { fieldName, type: fieldType } of fieldStatsEntries.filter(
+            (e) => e.isDependentVariableInput
+          )) {
+            await ml.dataFrameAnalyticsCreation.assertFieldStatsFlyoutContentFromDependentVariableInputTrigger(
+              fieldName,
+              fieldType,
+              testData.expected.fieldStatsValues && fieldName in testData.expected.fieldStatsValues
+                ? (testData.expected.fieldStatsValues[fieldName] as string[])
+                : undefined
+            );
+          }
 
           await ml.testExecution.logTestStep('inputs the dependent variable');
-          await ml.dataFrameAnalyticsCreation.assertDependentVariableInputExists();
           await ml.dataFrameAnalyticsCreation.selectDependentVariable(testData.dependentVariable);
 
           await ml.testExecution.logTestStep('inputs the training percent');
@@ -308,6 +352,19 @@ export default function ({ getService }: FtrProviderContext) {
           await ml.testExecution.logTestStep('displays the include fields selection');
           await ml.dataFrameAnalyticsCreation.assertIncludeFieldsSelectionExists();
 
+          await ml.testExecution.logTestStep('opens field stats flyout from include fields input');
+          for (const { fieldName, type: fieldType } of fieldStatsEntries.filter(
+            (e) => e.isIncludeFieldInput
+          )) {
+            await ml.dataFrameAnalyticsCreation.assertFieldStatFlyoutContentFromIncludeFieldTrigger(
+              fieldName,
+              fieldType,
+              testData.expected.fieldStatsValues && fieldName in testData.expected.fieldStatsValues
+                ? (testData.expected.fieldStatsValues[fieldName] as string[])
+                : undefined
+            );
+          }
+
           await ml.testExecution.logTestStep('continues to the additional options step');
           await ml.dataFrameAnalyticsCreation.continueToAdditionalOptionsStep();
 

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts
@@ -5,8 +5,9 @@
  * 2.0.
  */
 
-import { FtrProviderContext } from '../../../ftr_provider_context';
-import { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
+import type { FtrProviderContext } from '../../../ftr_provider_context';
+import type { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
+import type { FieldStatsType } from './types';
 
 export default function ({ getService }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
@@ -16,7 +17,7 @@ export default function ({ getService }: FtrProviderContext) {
   describe('outlier detection creation', function () {
     before(async () => {
       await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/ihp_outlier');
-      await ml.testResources.createIndexPatternIfNeeded('ft_ihp_outlier', '@timestamp');
+      await ml.testResources.createIndexPatternIfNeeded('ft_ihp_outlier');
       await ml.testResources.setKibanaTimeZoneToUTC();
 
       await ml.securityUI.loginAsMlPowerUser();
@@ -29,6 +30,14 @@ export default function ({ getService }: FtrProviderContext) {
 
     const jobId = `ihp_1_${Date.now()}`;
 
+    const fieldStatsEntries = [
+      {
+        fieldName: '1stFlrSF',
+        type: 'keyword' as FieldStatsType,
+        isIncludeFieldInput: true,
+      },
+    ];
+
     const testDataList = [
       {
         suiteTitle: 'iowa house prices',
@@ -171,6 +180,16 @@ export default function ({ getService }: FtrProviderContext) {
           await ml.testExecution.logTestStep('displays the include fields selection');
           await ml.dataFrameAnalyticsCreation.assertIncludeFieldsSelectionExists();
 
+          await ml.testExecution.logTestStep('opens field stats flyout from include fields input');
+          for (const { fieldName, type: fieldType } of fieldStatsEntries.filter(
+            (e) => e.isIncludeFieldInput
+          )) {
+            await ml.dataFrameAnalyticsCreation.assertFieldStatFlyoutContentFromIncludeFieldTrigger(
+              fieldName,
+              fieldType
+            );
+          }
+
           await ml.testExecution.logTestStep(
             'sets the sample size to 10000 for the scatterplot matrix'
           );

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts
@@ -5,18 +5,33 @@
  * 2.0.
  */
 
-import { FtrProviderContext } from '../../../ftr_provider_context';
-import { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
+import type { FtrProviderContext } from '../../../ftr_provider_context';
+import type { AnalyticsTableRowDetails } from '../../../services/ml/data_frame_analytics_table';
+import type { FieldStatsType } from './types';
 
 export default function ({ getService }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
   const ml = getService('ml');
   const editedDescription = 'Edited description';
 
+  const fieldStatsEntries = [
+    {
+      fieldName: 'g1',
+      type: 'number' as FieldStatsType,
+      isDependentVariableInput: true,
+      isIncludeFieldInput: true,
+    },
+    {
+      fieldName: 'g2',
+      type: 'number' as FieldStatsType,
+      isIncludeFieldInput: true,
+    },
+  ];
+
   describe('regression creation', function () {
     before(async () => {
       await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/egs_regression');
-      await ml.testResources.createIndexPatternIfNeeded('ft_egs_regression', '@timestamp');
+      await ml.testResources.createIndexPatternIfNeeded('ft_egs_regression');
       await ml.testResources.setKibanaTimeZoneToUTC();
 
       await ml.securityUI.loginAsMlPowerUser();
@@ -38,6 +53,7 @@ export default function ({ getService }: FtrProviderContext) {
         get destinationIndex(): string {
           return `user-${jobId}`;
         },
+        fieldStatsEntries,
         runtimeFields: {
           uppercase_stab: {
             type: 'keyword',
@@ -132,8 +148,20 @@ export default function ({ getService }: FtrProviderContext) {
             testData.expected.runtimeFieldsEditorContent
           );
 
-          await ml.testExecution.logTestStep('inputs the dependent variable');
+          await ml.testExecution.logTestStep(
+            'opens field stats flyout from dependent variable input'
+          );
           await ml.dataFrameAnalyticsCreation.assertDependentVariableInputExists();
+          for (const { fieldName, type: fieldType } of fieldStatsEntries.filter(
+            (e) => e.isDependentVariableInput
+          )) {
+            await ml.dataFrameAnalyticsCreation.assertFieldStatsFlyoutContentFromDependentVariableInputTrigger(
+              fieldName,
+              fieldType
+            );
+          }
+
+          await ml.testExecution.logTestStep('inputs the dependent variable');
           await ml.dataFrameAnalyticsCreation.selectDependentVariable(testData.dependentVariable);
 
           await ml.testExecution.logTestStep('inputs the training percent');
@@ -146,6 +174,16 @@ export default function ({ getService }: FtrProviderContext) {
           await ml.testExecution.logTestStep('displays the include fields selection');
           await ml.dataFrameAnalyticsCreation.assertIncludeFieldsSelectionExists();
 
+          await ml.testExecution.logTestStep('opens field stats flyout from include fields input');
+          for (const { fieldName, type: fieldType } of fieldStatsEntries.filter(
+            (e) => e.isIncludeFieldInput
+          )) {
+            await ml.dataFrameAnalyticsCreation.assertFieldStatFlyoutContentFromIncludeFieldTrigger(
+              fieldName,
+              fieldType
+            );
+          }
+
           await ml.testExecution.logTestStep(
             'sets the sample size to 10000 for the scatterplot matrix'
           );

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/types.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/types.ts
@@ -0,0 +1,8 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+export type FieldStatsType = 'number' | 'keyword' | 'date';