Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate the new github code review system #29

Closed
thatkookooguy opened this issue Jan 20, 2017 · 1 comment
Closed

integrate the new github code review system #29

thatkookooguy opened this issue Jan 20, 2017 · 1 comment

Comments

@thatkookooguy
Copy link
Member

alongside the assignee mechanism

@thatkookooguy
Copy link
Member Author

Almost there!

hooked to all the events and parsed the data from GitHub.

now, I just need to change the assignees to not be reviewers :-)

and do some basic tests

screen shot 2017-02-06 at 18 38 35

Currently, I'm thinking of adding the following fields:

{
  reviewers: [], // array of reviewers
  assignees: [], // array of assignees ( old reviewers )
  history: {
    reviewers: {
      removed: [] // array of removed reviewers
    }
  }
}

@Kibibit/development tell me if you guys have a different idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant