Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1650: The user can navigate to their inbox from the app #1038

Merged
merged 5 commits into from
Nov 10, 2020

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Nov 10, 2020

📲 What

When the user taps "Open Inbox", they will either be taken to their default application, or shown a list of apps that they can choose from to open their email. If they have no apps available for email, it will show an "empty state" bottom sheet.

🤔 Why

We want users to be able to open their inbox application immediately upon receiving the verification email from kickstarter.

🛠 How

When the user taps on the "Open Inbox" button, the viewmodel responds by sending at intent with parameters attached that indicate we would like to open an email application. This is built into the Android framework.

👀 See

Nov-10-2020 11-24-53

📋 QA

  • Tap on ovreflow menu
  • Tap on "Internal Tools"
  • Scroll to bottom, tap "Email Verification Interstitial"
  • Tap "Open Inbox"
  • Default email app or a list of email applications should appear.

Story 📖

NT-1650: The user can navigate to their inbox from the app



init {
openInboxButtonPressed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add in here this.openInboxButtonPressed we do explicitly call this. for the global variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it 👍

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍

@leighdouglas leighdouglas changed the title NT1650 open email inbox NT-1650: The user can navigate to their inbox from the app Nov 10, 2020
@leighdouglas leighdouglas merged commit 9dc91a7 into master Nov 10, 2020
@leighdouglas leighdouglas deleted the leigh/NT-1650-open-email-inbox branch November 10, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants