[Android] EP-390: Phase 1 QA Feedback Priority 2 properties #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighdouglas
commented
Mar 25, 2021
| @@ -113,7 +113,7 @@ protected String deviceFormat() { | |||
|
|
|||
| @Override | |||
| protected String deviceOrientation() { | |||
| return "Portrait"; | |||
| return "portrait"; | |||
There was a problem hiding this comment.
This will be removed once the previous PR is landed and I rebase.
leighdouglas
force-pushed
the
ep-390-qa-p2
branch
from
cd806ee
to
96ed4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摬 What
Added 3 new props to user properties:
user_created_projects_countuser_facebook_connecteduser_watched_projects_countUpdated the
SegmentTestsuite馃 Why
Segment integration.
馃洜 How
userProperties()function in theAnalyticEventsUtilsextassertUserProperties()function in theSegmentTestclass as well as the test case that checks we are returning the correct value if the fields from v1 that are populating these properties are null馃搵 QA
Story 馃摉
EP-390: [Android] Create Properties Phase 1 QA Feedback Priority 2