Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-1832: Default Icon for Braze Push Notification #1204

Merged
merged 5 commits into from
Apr 13, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

  • added braze.xml resources file
  • added default icon
  • added background color for the icon

🛠 How

  • Braze SDK will look into braze.xml for resources

👀 See

| Before 🐛 | After 🦋 |
Screen Shot 2021-04-12 at 2 22 50 PM

| | |

📋 QA

  • Described on comments on this ticket how to QA this work Braze-PushNotifications just make sure the icon now is the kickstarter logo

Story 📖

NT-1832

@Arkariang Arkariang changed the title NT-1832: Default Push Notification Icons from Braze NT-1832: Default Icon for Braze Push Notification Apr 12, 2021
@Arkariang Arkariang marked this pull request as ready for review April 12, 2021 21:50
@Arkariang Arkariang closed this Apr 12, 2021
@Arkariang Arkariang deleted the imartin/NT-1832-pushNotification-icon branch April 12, 2021 23:25
@Arkariang Arkariang restored the imartin/NT-1832-pushNotification-icon branch April 12, 2021 23:25
@Arkariang Arkariang reopened this Apr 12, 2021
@leighdouglas leighdouglas self-assigned this Apr 13, 2021
@leighdouglas
Copy link
Contributor

LGTM! 🎉

@Arkariang Arkariang merged commit 62dcbf8 into master Apr 13, 2021
@Arkariang Arkariang deleted the imartin/NT-1832-pushNotification-icon branch April 13, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants