-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NT-1969: UX – Show last page of replies #1299
NT-1969: UX – Show last page of replies #1299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
=========================================
Coverage 74.34% 74.34%
Complexity 739 739
=========================================
Files 221 221
Lines 6646 6646
Branches 405 405
=========================================
Hits 4941 4941
Misses 1569 1569
Partials 136 136 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments here, nothing big :) .
Solve the conflicts and we can properly review it again
app/src/main/java/com/kickstarter/viewmodels/CommentsViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
import com.kickstarter.models.Project | ||
import com.kickstarter.ui.data.CommentCardData | ||
|
||
fun List<Comment>.toCommentCardList(project: Project?): List<CommentCardData> = this.map { comment: Comment -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch 👍
…starter/android-oss into sunday-nt-1969-ux-show-last-replies
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some UI tweecks needed. as shown on the screenshoots
android:orientation="vertical" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content"/> | ||
<androidx.recyclerview.widget.RecyclerView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍 great work here @sunday-okpoluaefe
Fix the lister check and is good to go |
…ure/NT-2059-update-stripe-sdk * 'master' of github.com:kickstarter/android-oss: NT-1989: Removed any code related with "Email Verification" feature flag, no related code on the app for "Go Rewardless", "Native Checkout", and "Creator View" (#1302) NT-1969: UX – Show last page of replies (#1299) - Release 2.16.0 version code
📲 What
UX – Show last page of replies
🤔 Why
🛠 How
👀 See
scroller.convert-video-online.com.mp4
📋 QA
View replies
Story 📖
https://kickstarter.atlassian.net/browse/NT-1969