NT-1969: UX – Show last page of replies #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
=========================================
Coverage 74.34% 74.34%
Complexity 739 739
=========================================
Files 221 221
Lines 6646 6646
Branches 405 405
=========================================
Hits 4941 4941
Misses 1569 1569
Partials 136 136 Continue to review full report at Codecov.
|
Arkariang
reviewed
Jun 22, 2021
app/src/main/java/com/kickstarter/viewmodels/CommentsViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
| import com.kickstarter.models.Project | ||
| import com.kickstarter.ui.data.CommentCardData | ||
|
|
||
| fun List<Comment>.toCommentCardList(project: Project?): List<CommentCardData> = this.map { comment: Comment -> |
…starter/android-oss into sunday-nt-1969-ux-show-last-replies
done |
Arkariang
reviewed
Jun 22, 2021
Arkariang
requested changes
Jun 22, 2021
| android:orientation="vertical" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content"/> | ||
| <androidx.recyclerview.widget.RecyclerView |
There was a problem hiding this comment.
Add constraints for this two elements. When there is only one reply the UI shows like this:
Arkariang
approved these changes
Jun 22, 2021
|
Fix the lister check and is good to go |
Arkariang
added a commit
that referenced
this pull request
Jun 23, 2021
…ure/NT-2059-update-stripe-sdk * 'master' of github.com:kickstarter/android-oss: NT-1989: Removed any code related with "Email Verification" feature flag, no related code on the app for "Go Rewardless", "Native Checkout", and "Creator View" (#1302) NT-1969: UX – Show last page of replies (#1299) - Release 2.16.0 version code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
UX – Show last page of replies
🤔 Why
🛠 How
👀 See
scroller.convert-video-online.com.mp4
📋 QA
View repliesStory 📖
https://kickstarter.atlassian.net/browse/NT-1969