Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NT-2095:View Replies show and hide with scrolling #1312

Merged
merged 4 commits into from
Jul 6, 2021
Merged

NT-2095:View Replies show and hide with scrolling #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec6157b
chain with isCommentEnableThreads
hadia Jul 5, 2021
35ac23f
Merge branch 'master' into fix/view_repies_binding
Arkariang Jul 5, 2021
40e51d6
Merge branch 'master' into fix/view_repies_binding
hadia Jul 5, 2021
cfb24cb
Fix test
hadia Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/kickstarter/viewmodels/CommentsViewHolderViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,11 @@ interface CommentsViewHolderViewModel {

comment
.map { it.repliesCount() }
.compose(combineLatestPair(this.isCommentEnableThreads))
.compose(bindToLifecycle())
.subscribe(this.commentRepliesCount)
.subscribe {
this.commentRepliesCount.onNext(it.first)
}

comment
.map { it.author()?.name() }
Expand Down
11 changes: 9 additions & 2 deletions app/src/test/java/com/kickstarter/viewmodels/CommentsViewHolderViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import org.junit.Test
import rx.Observable
import rx.observers.TestSubscriber
import rx.schedulers.TestScheduler
import rx.subjects.BehaviorSubject
import java.util.concurrent.TimeUnit

class CommentsViewHolderViewModelTest : KSRobolectricTestCase() {
Expand Down Expand Up @@ -285,11 +286,17 @@ class CommentsViewHolderViewModelTest : KSRobolectricTestCase() {

@Test
fun testSetRepliesCount() {
setUpEnvironment(environment())
val repliesCount = BehaviorSubject.create<Int>()

val environment = optimizelyFeatureFlagOn().toBuilder()
.currentUser(MockCurrentUser(UserFactory.user()))
.build()
setUpEnvironment(environment)
val comment = CommentFactory.comment(repliesCount = 1)
val commentData = CommentCardData.builder().comment(comment).project(ProjectFactory.project()).build()
this.vm.outputs.commentRepliesCount().subscribe(repliesCount)
this.vm.inputs.configureWith(commentData)
this.repliesCount.assertValue(comment.repliesCount())
assertEquals(comment.repliesCount(), repliesCount.value)
}

private fun optimizelyFeatureFlagOn() = environment().toBuilder()
Expand Down