NT-2095:View Replies show and hide with scrolling #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as soon as the failing test is fixed feel free to merge |
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
=========================================
Coverage 74.12% 74.12%
Complexity 739 739
=========================================
Files 221 221
Lines 6666 6666
Branches 406 406
=========================================
Hits 4941 4941
Misses 1589 1589
Partials 136 136 Continue to review full report at Codecov.
|
Arkariang
added a commit
that referenced
this pull request
Jul 6, 2021
…ure/NT-2059-update-stripe-sdk * 'master' of github.com:kickstarter/android-oss: NT-1997:UI/UX – Error loading more replies (#1313) NT-2095:View Replies show and hide with scrolling (#1312) NT-2053:UX – Add pagination to replies (#1311) NT-2028: Navigation – Back button should slide view out #1310 NT-1958: UX – Post a reply (#1305) NT-2071: Update exoplayer, mockito, and timber dependencies to latest versions (#1306) Set the name as an empty string to prevent the app from crashing. (#1309) NT-2069:Refactor Comment Pagination code (#1308) NT-2005: Update Dependencies to Latest Version (#1304) NT-2069:Refactor Comment Pagination code (#1303) NT-1958: UX – Post a reply (#1301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
View Replies show and hide with scrolling
🤔 Why
the comment replies bind before checking the feature flag
🛠 How
chain the events
👀 See
| Before 🐛 |
device-2021-07-05-185423.mp4
| After 🦋 |
https://user-images.githubusercontent.com/1075310/124510632-8c34ae00-ddd4-11eb-9523-4f74f21c5093.mp4
📋 QA
1- open "Elementallis - A Zelda-like with Elemental magic gameplay"
2- check the second comment for "paulo" the "view replies" is hidden
3- scroll down and then scroll to comment it appear
Story 📖
https://kickstarter.atlassian.net/browse/NT-2095