Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2173: Private CI workflow failing fixed #1346

Merged
merged 9 commits into from Aug 5, 2021

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Aug 4, 2021

📲 What

  • Rollback the adoption of Android Machine executor, and use again docker image with API 30.
  • Snapshot test job has been commented, it won't be executed

| | |

📋 QA

Story 📖

NT-2173

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #1346 (f6d3970) into master (18b5cdf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1346   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6669     6669           
  Branches        409      409           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b5cdf...f6d3970. Read the comment docs.

@Arkariang Arkariang changed the title NT-2173: Private CI workflow failing NT-2173: Private CI workflow failing fixed Aug 4, 2021
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefect👌

@Arkariang Arkariang merged commit 6c9dba9 into master Aug 5, 2021
@Arkariang Arkariang deleted the imartin/private-ci-workflow-failing branch August 5, 2021 17:49
Arkariang added a commit that referenced this pull request Aug 5, 2021
…tin/update-gems

* 'master' of github.com:kickstarter/android-oss:
  NT-2173: Private CI workflow failing fixed (#1346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants