Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-2141: Stepper component #1344

Merged
merged 18 commits into from
Aug 4, 2021
Merged

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Aug 4, 2021

📲 What

  • Migrated to kotlin the Playground activity in order to test the new components
  • Create a reusable component as the stepper on the addOns card

🛠 How

  • The stepper can configure as input Max, Min, initial value, and the increment value.
  • The stepper has as output the displayed number
  • Once reached the Max limit or the Min limit the increase/decrease buttons on the stepper are disabled.

👀 See

stepper.mp4

| | |

📋 QA

  • Open the playground activity on the internal tools screen, and play around with the stepper

Story 📖

[Name of Trello Story](Trello link)

@Arkariang Arkariang marked this pull request as ready for review August 4, 2021 16:09
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #1344 (889b557) into master (6fa2555) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1344   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity      743      743           
=========================================
  Files           221      221           
  Lines          6669     6669           
  Branches        409      409           
=========================================
  Hits           4946     4946           
  Misses         1584     1584           
  Partials        139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa2555...889b557. Read the comment docs.

Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job🎉🎉

@Arkariang Arkariang merged commit 18b5cdf into master Aug 4, 2021
@Arkariang Arkariang deleted the imartin/NT-2141-stepper-component branch August 4, 2021 18:19
Arkariang added a commit that referenced this pull request Aug 4, 2021
…tin/private-ci-workflow-failing

* 'master' of github.com:kickstarter/android-oss:
  NT-2141: Stepper component (#1344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants