NTV-207: Project overview first PR #1420

Arkariang · 2021-10-07T22:38:48Z

📲 What

Re-use what we could from the old ProjecViewHolder & ProjectViewModel and xml counterparts
ViewModel and test migrated to kotlin for the overview.
Some refactoring around Intents & activies, migrated all the logic to Extensions
*** ⚠️ on next PR more refactoring on ProjectPage the TODO will guide those.

👀 See

ProjectOverview.mp4

| | |

📋 QA

You can see project data on the project overview fragment
You can navigate to Comments screen
You can navigate to Updates screen
You can navigate to Creator Bio screen
You can navigate to Creator dashboard screen

Story 📖

NTV-207

…tation

…ents_Implementation

…tation

- kotlin

…tin/NTV-207-project-overview * 'master' of github.com:kickstarter/android-oss: NTV-211:Environmental Commitments Implementation (#1418)

…tin/NTV-207-project-overview * 'master' of github.com:kickstarter/android-oss: NTV-235:Ask a question (#1419)

…dded

codecov · 2021-10-07T23:00:25Z

Codecov Report

Merging #1420 (669bec2) into master (e553c8d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1420      +/-   ##
============================================
+ Coverage     72.24%   72.27%   +0.03%     
- Complexity      738      739       +1     
============================================
  Files           211      211              
  Lines          6085     6085              
  Branches        391      391              
============================================
+ Hits           4396     4398       +2     
+ Misses         1551     1549       -2     
  Partials        138      138

Impacted Files	Coverage Δ
.../src/main/java/com/kickstarter/models/Project.java	`63.49% <0.00%> (+3.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e553c8d...669bec2. Read the comment docs.

- avatar on friends list

leighdouglas · 2021-10-08T15:36:35Z

app/src/main/java/com/kickstarter/libs/utils/extensions/IntentExt.kt

+ * @param projectAndData
+ * @param comment -> to open the comments activity to a specific thread
+ */
+fun Intent.getRootCommentsActivityIntent(


leighdouglas · 2021-10-08T15:37:23Z

app/src/main/java/com/kickstarter/ui/activities/ProjectPageActivity.kt

@@ -702,68 +718,6 @@ class ProjectPageActivity :
        overridePendingTransition(R.anim.slide_in_right, R.anim.fade_out_slide_out_left)
    }

-    private fun startCreatorBioWebViewActivity(project: Project) {


👏🏽 👏🏽 👏🏽

leighdouglas

This looks so great! Awesome! Just have to fix that failing test but this looks great 🚀

hadia and others added 29 commits September 29, 2021 17:40

Fix ui issue

0b9af8e

Merge branch 'master' into hadia/Fix_FQA_issue

736b65c

create EnvironmentalCommitmentsCard with snap shot testing

4c33adf

Merge branch 'master' into NTV-211_Environmental_Commitments_Implemen…

e315ad4

…tation

EnvironmentalCommitmentsAdapter List

2debf0e

Add test classes

fa9a938

Merge branch 'master' into NTV-211_Environmental_Commitments_Implemen…

72961df

…tation

Merge branch 'hadia/Fix_FQA_issue' into NTV-211_Environmental_Commitm…

d4f813e

…ents_Implementation

Add test to hide tabs

a4dc667

Fix code format

7a4c56d

Merge branch 'master' into NTV-211_Environmental_Commitments_Implemen…

53a09e8

…tation

- Loaded entire project overview! first steps

4f555cc

- Added tests

458f9b4

- linter

6bdbb94

- kotlin

- linter

98ee376

- linter

6e3e0d4

- Kotlin refactor

5472a6b

- Fix tests

b2613da

- clean up

568a119

Merge branch 'master' of github.com:kickstarter/android-oss into imar…

997a312

…tin/NTV-207-project-overview * 'master' of github.com:kickstarter/android-oss: NTV-211:Environmental Commitments Implementation (#1418)

- Remove unnecessary outputs

25b9cd0

- updated tests

b512f04

- remove red more about campaign button

acd66a1

- inputs

8d4aa5f

Merge branch 'master' of github.com:kickstarter/android-oss into imar…

f6570e7

…tin/NTV-207-project-overview * 'master' of github.com:kickstarter/android-oss: NTV-235:Ask a question (#1419)

- Refactoring stuff

4021291

- Refactored a little bit Intent extension added, acivity extension a…

eae798a

…dded

- Added all the intents for activities

88c520d

- Final re-touch

24f2db4

Arkariang marked this pull request as ready for review October 7, 2021 23:01

Arkariang added feature ✨ UI 🎨 labels Oct 7, 2021

Arkariang requested review from leighdouglas and hadia October 7, 2021 23:02

- fix first loading issue

ff957f8

- avatar on friends list

leighdouglas reviewed Oct 8, 2021

View reviewed changes

leighdouglas approved these changes Oct 8, 2021

View reviewed changes

- Remove hardcoded for qa :(

669bec2

Arkariang merged commit 12c2ae5 into master Oct 8, 2021

Arkariang deleted the imartin/NTV-207-project-overview branch October 8, 2021 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NTV-207: Project overview first PR #1420

NTV-207: Project overview first PR #1420

Arkariang commented Oct 7, 2021 •

edited

codecov bot commented Oct 7, 2021 •

edited

leighdouglas Oct 8, 2021

leighdouglas Oct 8, 2021

leighdouglas left a comment •

edited

NTV-207: Project overview first PR #1420

NTV-207: Project overview first PR #1420

Conversation

Arkariang commented Oct 7, 2021 • edited

📲 What

👀 See

📋 QA

Story 📖

codecov bot commented Oct 7, 2021 • edited

Codecov Report

leighdouglas Oct 8, 2021

Choose a reason for hiding this comment

leighdouglas Oct 8, 2021

Choose a reason for hiding this comment

leighdouglas left a comment • edited

Choose a reason for hiding this comment

Arkariang commented Oct 7, 2021 •

edited

codecov bot commented Oct 7, 2021 •

edited

leighdouglas left a comment •

edited