Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-207: Added "Read More" link to campaign #1431

Merged
merged 2 commits into from Oct 26, 2021
Merged

NTV-207: Added "Read More" link to campaign #1431

merged 2 commits into from Oct 26, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Bring back the Reado more about the campaign text + clicking on campaign description will open the Campaign activity

🤔 Why

  • Added back until we have in place the Native campaign screen

🛠 How

More in-depth discussion of the change or implementation.

👀 See

campaignLink.mp4

| | |

📋 QA

  • Go to a project, click the description, it will open the campaign activity. Same action as if you scroll until the campaig link and click on it.

Story 📖

NTV-207y

@codecov
Copy link

codecov bot commented Oct 22, 2021 •
edited

Codecov Report

Merging #1431 (9ff5b70) into master (52f73e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1431   +/-   ##
=========================================
  Coverage     72.28%   72.28%           
  Complexity      738      738           
=========================================
  Files           211      211           
  Lines          6084     6084           
  Branches        391      391           
=========================================
  Hits           4398     4398           
  Misses         1548     1548           
  Partials        138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f73e9...9ff5b70. Read the comment docs.

leighdouglas
leighdouglas approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚀

@Arkariang Arkariang merged commit 486a82e into master Oct 26, 2021
@Arkariang Arkariang deleted the imartin/NTV-207 branch October 26, 2021 17:20
Arkariang added a commit that referenced this pull request Oct 26, 2021
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into imar…
1bc8b5a 
…tin/NTV-250-integrate-html-parser

* 'master' of github.com:kickstarter/android-oss:
  NTV-207: Added "Read More" link to campaign (#1431)
  NTV-211  Environmental Commitments Implementation (#1432)
  NTV-247 : Add Risks Fragment to navigation and implement UI (#1428)

# Conflicts:
#	app/src/main/java/com/kickstarter/ui/adapters/ProjectPagerAdapter.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@hadia hadia Awaiting requested review from hadia

Assignees
No one assigned
Labels
UI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arkariang @leighdouglas @hadia