Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-211 Environmental Commitments Implementation #1432

Merged
merged 2 commits into from Oct 26, 2021

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Oct 25, 2021

📲 What

Add padding on the bottom, after the link.
image

👀 See

image

📋 QA

Open project with Environmental Commitments "Sailor's Compass by Oceanus Brass"

Story 📖

https://kickstarter.atlassian.net/browse/NTV-211

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1432 (3b794c1) into master (8c8597b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1432   +/-   ##
=========================================
  Coverage     72.28%   72.28%           
  Complexity      738      738           
=========================================
  Files           211      211           
  Lines          6084     6084           
  Branches        391      391           
=========================================
  Hits           4398     4398           
  Misses         1548     1548           
  Partials        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8597b...3b794c1. Read the comment docs.

Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🎉

@hadia hadia merged commit 52f73e9 into master Oct 26, 2021
@hadia hadia deleted the hadia/Fix_environmental_comments_issue branch October 26, 2021 16:32
Arkariang added a commit that referenced this pull request Oct 26, 2021
…tin/NTV-250-integrate-html-parser

* 'master' of github.com:kickstarter/android-oss:
  NTV-207: Added "Read More" link to campaign (#1431)
  NTV-211  Environmental Commitments Implementation (#1432)
  NTV-247 : Add Risks Fragment to navigation and implement UI (#1428)

# Conflicts:
#	app/src/main/java/com/kickstarter/ui/adapters/ProjectPagerAdapter.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants