Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-306 : Migrate to Kotlin Extension Discovery Utils classes #1496

Merged
merged 16 commits into from Jan 11, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Dec 28, 2021

📲 What

Migrate to Kotlin Extension Discovery Utils classes

🛠 How

Migrate from Java to Kotlin extension the next Utils classes

DiscoveryUtils.java to DiscoveryUtils.Kt

DiscoveryParamsUtils.java And DiscoveryDrawerUtils.java toDiscoveryParamsExt.kt

Story 📖

https://kickstarter.atlassian.net/browse/NTV-306

@hadia hadia added the migration Migration Java to Kotlin label Dec 28, 2021
@Arkariang
Copy link
Contributor

two tests failing, once they are fixed, I'll review the PR
Screen Shot 2022-01-05 at 9 18 17 AM

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #1496 (3859191) into master (17065ad) will decrease coverage by 0.25%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1496      +/-   ##
============================================
- Coverage     72.07%   71.81%   -0.26%     
+ Complexity      591      542      -49     
============================================
  Files           189      186       -3     
  Lines          5564     5450     -114     
  Branches        308      287      -21     
============================================
- Hits           4010     3914      -96     
+ Misses         1465     1454      -11     
+ Partials         89       82       -7     
Impacted Files Coverage Δ
...kickstarter/ui/adapters/DiscoveryPagerAdapter.java 0.00% <0.00%> (ø)
...n/java/com/kickstarter/libs/utils/RefTagUtils.java 76.74% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17065ad...3859191. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hadia hadia merged commit 26b84b0 into master Jan 11, 2022
@hadia hadia deleted the hadia/NTV-306 branch January 11, 2022 11:36
Arkariang added a commit that referenced this pull request Jan 11, 2022
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  [no-jira]: Bug on UI  (#1506)
  NTV-337: PaymentSource Model (#1504)
  NTV-306 : Migrate to Kotlin Extension Discovery Utils classes (#1496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants