Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-337: PaymentSource Model #1504

Merged
merged 5 commits into from Jan 11, 2022
Merged

NTV-337: PaymentSource Model #1504

merged 5 commits into from Jan 11, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

🤔 Why

  • Remove all references to AutoParcel library in Models, eventually we will be able to remove that dependency.

👀 See

  • No user facing changes

| | |

📋 QA

  • Make a pledge with a card already storaged.
  • Add a new payment method
  • Update a pledge (⚠️ remember in staging updating a pledge for a project that has 0 seconds to finish will result in error, update a pledge in a project not finished yet).

Story 📖

NTV-337

@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited

Codecov Report

Merging #1504 (71cc18c) into master (26b84b0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1504      +/-   ##
============================================
- Coverage     71.81%   71.80%   -0.02%     
  Complexity      542      542              
============================================
  Files           186      186              
  Lines          5450     5447       -3     
  Branches        287      287              
============================================
- Hits           3914     3911       -3     
  Misses         1454     1454              
  Partials         82       82
Impacted Files Coverage Δ
.../src/main/java/com/kickstarter/models/Backing.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b84b0...71cc18c. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review January 7, 2022 14:53
@Arkariang Arkariang added maintenance 🗜 migration Migration Java to Kotlin labels Jan 7, 2022
@leighdouglas
Copy link
Contributor

Looks great @Arkariang, but will we be adding tests? Otherwise lgtm!

@Arkariang
Copy link
Contributor Author

@leighdouglas these 3 viewmodels cover the PaymentSource, it has been extracted from Backing
Screen Shot 2022-01-10 at 1 51 36 PM

hadia
hadia approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 😍

@Arkariang Arkariang merged commit 0a59f87 into master Jan 11, 2022
@Arkariang Arkariang deleted the imartin/NTV-337-paymentsource branch January 11, 2022 17:13
Arkariang added a commit that referenced this pull request Jan 11, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
4200359 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  [no-jira]: Bug on UI  (#1506)
  NTV-337: PaymentSource Model (#1504)
  NTV-306 : Migrate to Kotlin Extension Discovery Utils classes (#1496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadia hadia hadia approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees
No one assigned
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arkariang @leighdouglas @hadia