Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-50 :Posting a (root) comment #1509

Merged
merged 7 commits into from Jan 12, 2022
Merged

NTV-50 :Posting a (root) comment #1509

merged 7 commits into from Jan 12, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Jan 12, 2022

📲 What

Add Segment event when posting a new comment on:

  1. the project
  2. an update

🤔 Why

In order to keep track of comments usage

🛠 How

image

👀 See

Screen Shot 2022-01-11 at 4 17 36 PM

image

📋 QA

Post comments for the project and update and checks the segment events in case the comment is successfully posted

Story 📖

https://kickstarter.atlassian.net/browse/NTV-50

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1509 (7843157) into master (5563bbf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1509   +/-   ##
=========================================
  Coverage     69.30%   69.30%           
  Complexity      486      486           
=========================================
  Files           179      179           
  Lines          4881     4881           
  Branches        287      287           
=========================================
  Hits           3383     3383           
  Misses         1416     1416           
  Partials         82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5563bbf...7843157. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tested both on comment on a project, and comment on update
Screen Shot 2022-01-12 at 8 47 03 AM

Screen Shot 2022-01-12 at 8 47 17 AM

@hadia hadia merged commit 4dd0d25 into master Jan 12, 2022
@hadia hadia deleted the hadia/NTV-50 branch January 12, 2022 17:18
Arkariang added a commit that referenced this pull request Jan 12, 2022
…tin/NTV-336-project

* 'master' of github.com:kickstarter/android-oss:
  NTV-50 :Posting a (root) comment (#1509)
Arkariang added a commit that referenced this pull request Jan 13, 2022
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-51 : Posting a reply (#1511)
  NTV-336: Project Model (#1510)
  NTV-50 :Posting a (root) comment (#1509)
  NTV-335: Backing model (#1508)
  Revert "- Backing body"
  - Backing body
  NTV-334: Reward model (#1505)

# Conflicts:
#	app/src/main/java/com/kickstarter/models/Project.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants