Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-51 : Posting a reply #1511

Merged
merged 3 commits into from Jan 13, 2022
Merged

NTV-51 : Posting a reply #1511

merged 3 commits into from Jan 13, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Jan 13, 2022

📲 What

Add Segment event when posting a reply for root comment on:

  1. the project
  2. an update

🤔 Why

In order to keep track of comments usage

🛠 How

image

👀 See

Screen Shot 2022-01-13 at 3 34 10 PM
Screen Shot 2022-01-13 at 4 22 38 PM

📋 QA

Post reply For comments for the project and update and check the segment events in case the comment is successfully posted
Check deep link cases for reply

Story 📖

https://kickstarter.atlassian.net/browse/NTV-51

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1511 (ca6a00d) into master (f76a44f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1511   +/-   ##
=========================================
  Coverage     69.33%   69.33%           
  Complexity      453      453           
=========================================
  Files           178      178           
  Lines          4817     4817           
  Branches        285      285           
=========================================
  Hits           3340     3340           
  Misses         1397     1397           
  Partials         80       80           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76a44f...ca6a00d. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested on my environment
Screen Shot 2022-01-13 at 9 00 31 AM

@hadia hadia merged commit f1fc59a into master Jan 13, 2022
@hadia hadia deleted the hadia/NTV-51 branch January 13, 2022 17:36
Arkariang added a commit that referenced this pull request Jan 13, 2022
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-51 : Posting a reply (#1511)
  NTV-336: Project Model (#1510)
  NTV-50 :Posting a (root) comment (#1509)
  NTV-335: Backing model (#1508)
  Revert "- Backing body"
  - Backing body
  NTV-334: Reward model (#1505)

# Conflicts:
#	app/src/main/java/com/kickstarter/models/Project.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants