NTV-548: Unable to resolve host "api.kickstarter.com" #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved crash when opening a push notification
Codecov Report
@@ Coverage Diff @@
## master #1632 +/- ##
============================================
- Coverage 78.35% 78.34% -0.01%
Complexity 1862 1862
============================================
Files 353 353
Lines 16509 16502 -7
Branches 2031 2032 +1
============================================
- Hits 12936 12929 -7
+ Misses 2413 2412 -1
- Partials 1160 1161 +1
Continue to review full report at Codecov.
|
Arkariang
added a commit
that referenced
this pull request
Jun 6, 2022
…e/NTV-411-integrate-payment-sheet * 'master' of github.com:kickstarter/android-oss: versions and codes NTV-552 : Migrate BackingActivity ,BackingViewModel classes to kotlin (#1635) NTV-371 : Migrate `DiscoveryPagerAdapter.java` (#1630) NTV 547 : Migrate key classes to kotlin (#1633) NTV-546 Migrate qualifiers package Interface to Kotlin (#1631) NTV-550: Creator facing crash (#1634) NTV-548: Unable to resolve host "api.kickstarter.com" (#1632) [no-jira]: Update gradle & kotlin (#1556)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Steps to reproduce:
1 - Get a push notification (Can be one of the generated on internal tools like the project launch as showed in the video)
2 - Deactivate wifi or any networking on the app
3- Kill the app
4 - Open the push notification
5 - hit back button, at this point the app was crashing
🤔 Why
ApiOperator👀 See
| Before 🐛 |
crash.mp4
| After 🦋 |
no_crash.mp4
| | |
Story 📖
NTV-548