Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-550: Creator facing crash #1634

Merged
merged 2 commits into from Jun 1, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

The creator dashboard is crashing when scrolling to the bottom of the screen.

Steps to reproduce
1- Sign in with a creator account

2- Tap the hamburger button and tap “Dashboard” in the menu

3- On that screen, scroll to the bottom → crash occurs

👀 See

creator_facing_crash.mp4

| | |

Story 📖

NTV-550

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1634 (ed4c00d) into master (1a34192) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1634   +/-   ##
=========================================
  Coverage     78.34%   78.35%           
  Complexity     1862     1862           
=========================================
  Files           353      353           
  Lines         16502    16503    +1     
  Branches       2032     2031    -1     
=========================================
+ Hits          12929    12931    +2     
  Misses         2412     2412           
+ Partials       1161     1160    -1     
Impacted Files Coverage Δ
...rter/services/apiresponses/ProjectStatsEnvelope.kt 80.93% <100.00%> (+0.31%) ⬆️
...atorDashboardReferrerBreakdownHolderViewModel.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a34192...ed4c00d. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review May 31, 2022 23:20
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nice job 👌

@Arkariang Arkariang merged commit abf5801 into master Jun 1, 2022
@Arkariang Arkariang deleted the imartin/NTV-550-creator-dashboard-crash branch June 1, 2022 14:59
Arkariang added a commit that referenced this pull request Jun 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss:
  versions and codes
  NTV-552 : Migrate BackingActivity ,BackingViewModel classes to kotlin (#1635)
  NTV-371 :  Migrate `DiscoveryPagerAdapter.java` (#1630)
  NTV 547 : Migrate key classes to kotlin (#1633)
  NTV-546   Migrate qualifiers package Interface to Kotlin (#1631)
  NTV-550: Creator facing crash (#1634)
  NTV-548: Unable to resolve host "api.kickstarter.com" (#1632)
  [no-jira]: Update gradle & kotlin  (#1556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants