WEB-566: [Android] UI for flagged comment #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1643 +/- ##
=========================================
Coverage 78.43% 78.43%
Complexity 1862 1862
=========================================
Files 353 353
Lines 16573 16573
Branches 2039 2039
=========================================
Hits 12999 12999
Misses 2406 2406
Partials 1168 1168
Continue to review full report at Codecov.
|
Arkariang
reviewed
Jun 15, 2022
| android:id="@+id/flagged_message" | ||
| style="@style/CommentCardFlaggedMessage" | ||
| android:visibility="gone" | ||
| android:text="@string/this_comment_is_under_review" |
There was a problem hiding this comment.
Question here @leighdouglas, is there any ticket prepared for translations?
There was a problem hiding this comment.
Good point! I'll create that 👍🏽
Arkariang
reviewed
Jun 15, 2022
Arkariang
approved these changes
Jun 15, 2022
leighdouglas
force-pushed
the
leigh/ntv-566-flagged-ui
branch
from
d289944
to
eeb413b
Compare
Arkariang
added a commit
that referenced
this pull request
Jul 6, 2022
…tin/PAY-1693-integrate-paymentsheet * 'master' of github.com:kickstarter/android-oss: WEB-605: Update string for flagged comments (#1650) NTV-563 : Migrate Message related viewmodels classes to Kotlin (#1649) WEB-567: Show flagged comment UI/state when pending T&S review (#1648) - Release 3.3.0 Comments from canceled backers with no replies do not appear in the list of comments (#1645) NTV-561: Update dependencies (#1646) WEB-566: [Android] UI for flagged comment (#1643) NTV-560: Updated gems (#1644) PAY-1716: Update stripe SDK (#1642) NTV-556 : Migrate Creator Dashboard viewmodels classes to Kotlin (#1639) WEB-532 : [Android] Canceled backer: Remove "show comment" link from comment tombstones (#1641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Created comment card UI for flagged comment state.
🤔 Why
As a part of comment moderation updates, we want to hide potentially abusive comments from users while they are under review.
🛠 How
Created the new UI state for flagged comments, updated the comment card layout and class, and created screenshot tests.
👀 See
I censored the usernames as these were tests and those comments were not actually flagged.
📋 QA
Story 📖
WEB-566: [Android] UI for flagged comment