WEB-567: Show flagged comment UI/state when pending T&S review #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighdouglas
force-pushed
the
leigh/web-567-flagged-state
branch
from
e5982d5
to
b7271ac
Compare
leighdouglas
changed the title
Arkariang
approved these changes
Jun 23, 2022
Arkariang
added a commit
that referenced
this pull request
Jun 30, 2022
…tin/NTV-562 * 'master' of github.com:kickstarter/android-oss: WEB-567: Show flagged comment UI/state when pending T&S review (#1648) - Release 3.3.0 Comments from canceled backers with no replies do not appear in the list of comments (#1645) NTV-561: Update dependencies (#1646) # Conflicts: # app/build.gradle # app/src/test/java/com/kickstarter/viewmodels/CommentsViewHolderViewModelTest.kt
Arkariang
added a commit
that referenced
this pull request
Jul 6, 2022
…tin/PAY-1693-integrate-paymentsheet * 'master' of github.com:kickstarter/android-oss: WEB-605: Update string for flagged comments (#1650) NTV-563 : Migrate Message related viewmodels classes to Kotlin (#1649) WEB-567: Show flagged comment UI/state when pending T&S review (#1648) - Release 3.3.0 Comments from canceled backers with no replies do not appear in the list of comments (#1645) NTV-561: Update dependencies (#1646) WEB-566: [Android] UI for flagged comment (#1643) NTV-560: Updated gems (#1644) PAY-1716: Update stripe SDK (#1642) NTV-556 : Migrate Creator Dashboard viewmodels classes to Kotlin (#1639) WEB-532 : [Android] Canceled backer: Remove "show comment" link from comment tombstones (#1641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We want to show a comment flagged state for comments that have been flagged but not yet reviewed by T&S.
🤔 Why
Comment moderation updates.
🛠 How
Specs:
Fields
sustainedandhasFlaggingswere added to the graphQL struct.Added a method to
CommentExtthat checks ifhasFlaggings == true,sustained == false,deleted == false, and!currentUser.id == author.id().This is all gated by the feature flag
ANDROID_COMMENT_MODERATION👀 See
Flagged:
User is author:
📋 QA
Test all states of flagged comments:
Make sure to QA both project and update comments
Story 📖
WEB-567: Show flagged comment UI/state when pending T&S review