Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-807: ActivityFeed migrated to RXJava2 #1929

Merged
merged 4 commits into from
Jan 16, 2024
Merged

MBL-807: ActivityFeed migrated to RXJava2 #1929

merged 4 commits into from
Jan 16, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jan 12, 2024

📲 What

  • Migration RXJava2 + ViewModel, take a look at the engineering plan if any doubt
  • android.defaults.buildfeatures.buildconfig (deprecated) moved to gradle.build

| | |

📋 QA

  • Poke around the ActivityFeed

Story 📖

MBL-799

@Arkariang Arkariang added migration Migration Java to Kotlin refactor 🛠 and removed migration Migration Java to Kotlin labels Jan 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac0203c) 74.09% compared to head (e1ee1cb) 74.06%.

Files Patch % Lines
...s/rx/transformers/IncrementalCountTransformerV2.kt 57.14% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1929      +/-   ##
============================================
- Coverage     74.09%   74.06%   -0.03%     
  Complexity     1967     1967              
============================================
  Files           336      337       +1     
  Lines         19634    19642       +8     
  Branches       2716     2716              
============================================
+ Hits          14547    14548       +1     
- Misses         3499     3506       +7     
  Partials       1588     1588              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang merged commit d5ce29a into master Jan 16, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-807 branch January 16, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants