Fix Add-ons field not appearing on pledge screen #1937
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add-ons view was not being populated on pledge screen. Also the delivery date view was overlapping with a divider so I fixed that too.
🤔 Why
We needed to import android.util.Pair otherwise it defaults to kotlin.Pair and the data never gets observed.
🛠 How
Import android.util.Pair and change the Guideline constraint % from left from 0.60 to 0.65 to keep delivery date to one line
👀 See
📋 QA
Back a project with add-on’s. On pledge screen, tap the expandable caret button. Verify itemized list is displaying correctly.
Story 📖
https://kickstarter.atlassian.net/browse/MBL-1155