Creator tools header #204
Merged
Creator tools header #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we set some time aside this sprint for visual polish (getting the spacing and type sizing right), or set it aside for a later, general, UI sweep? |
|
@dannyalright Thanks for the strings PR! And I think it should be this sprint or when we're getting ready to release this feature! |
Merged
eoji
commented
Jan 24, 2018
| @@ -60,6 +69,21 @@ protected void onCreate(final @Nullable Bundle savedInstanceState) { | |||
| .compose(bindToLifecycle()) | |||
| .compose(observeForUI()) | |||
| .subscribe(this::newProjectClicked); | |||
|
|
|||
| final BottomSheetBehavior.BottomSheetCallback bottomSheetCallback = new BottomSheetBehavior.BottomSheetCallback() { | |||
There was a problem hiding this comment.
Make this a private method for readability.
| @@ -18,6 +20,7 @@ | |||
| void projectSwitcherProjectClicked(); | |||
| } | |||
| interface Outputs { | |||
| Observable<DateTime> projectLaunchDate(); | |||
| @@ -34,16 +34,16 @@ | |||
| } | |||
|
|
|||
| interface Outputs { | |||
| /* project and associated stats object */ | |||
| /** project and associated stats object */ | |||
There was a problem hiding this comment.
For consistency, let's make these proper sentences.
| @@ -5,11 +5,9 @@ | |||
| xmlns:tools="http://schemas.android.com/tools" | |||
There was a problem hiding this comment.
Let's see if we can move the new toolbar design here.
| @@ -1,176 +1,220 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout | |||
| android:id="@+id/creator_dashboard_funding_view" | |||
There was a problem hiding this comment.
See if we can extract styles from the new funding rows.
| android:layout_width="match_parent" | ||
| android:layout_height="1dp" | ||
| android:background="@color/ksr_dark_grey_500" | ||
| android:orientation="vertical" /> |
-javadoc -tests -cleanup
|
Bumping @cdolm92! I went through and addressed all our feedback from yesterday. |
cdolm92
approved these changes
Jan 25, 2018
Rcureton
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Creator tools header. * Cleanup and test updates. * updated strings and moving style to v-21 * lint * using proper "project" string * PR feedback -javadoc -tests -cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
New creator tools header designs.
馃憖