Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator tools funding #205

Merged
merged 15 commits into from
Jan 29, 2018
Merged

Creator tools funding #205

merged 15 commits into from
Jan 29, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Jan 23, 2018

what

Creator dashboard funding design updates.

  • Some spacing updates.
  • Progress bar color based on project state with tests ✨ .

👀

-javadoc
-tests
-cleanup
# Conflicts:
#	app/src/main/res/layout/dashboard_funding_view.xml
# Conflicts:
#	app/src/main/java/com/kickstarter/ui/viewholders/CreatorDashboardHeaderViewHolder.java
#	app/src/main/java/com/kickstarter/viewmodels/CreatorDashboardHeaderHolderViewModel.java
#	app/src/main/res/layout/dashboard_funding_view.xml
#	app/src/test/java/com/kickstarter/viewmodels/CreatorDashboardHeaderHolderViewModelTest.java
@eoji eoji mentioned this pull request Jan 26, 2018
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@eoji eoji merged commit 8d53fef into master Jan 29, 2018
@eoji eoji deleted the creator-tools-funding branch January 29, 2018 20:46
@eoji
Copy link
Contributor Author

eoji commented Jan 30, 2018

Rcureton pushed a commit that referenced this pull request Jul 31, 2018
* Creator tools funding design updates.
-Some spacing in the header layout.
-Progress bar color based on project state with tests.

* PR feedback from Nino, creating helper method for testing progress bar color from project state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants