Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove espresso #232

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Remove espresso #232

merged 1 commit into from
Apr 10, 2018

Conversation

bootstraponline
Copy link
Contributor

@bootstraponline bootstraponline commented Mar 29, 2018 •
edited
Loading

Fix #76

@eoji eoji self-requested a review April 9, 2018 20:19
eoji
eoji suggested changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bootstraponline, thanks for opening this PR. We've added our first instrumentation test here #235 so we will still need the last 3 imports for those tests. If you add those back, I can approve this PR to remove Espresso 👍

@bootstraponline
Copy link
Contributor Author

Updated.

@eoji eoji merged commit acd6987 into kickstarter:master Apr 10, 2018
@bootstraponline bootstraponline deleted the patch-1 branch April 10, 2018 15:26
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
@bootstraponline @eoji
Remove espresso (#232)
fe3b820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoji eoji eoji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bootstraponline @eoji