Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return of the referrer breakdown chart! #233

Merged
merged 2 commits into from Apr 3, 2018
Merged

return of the referrer breakdown chart! #233

merged 2 commits into from Apr 3, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Mar 29, 2018

what

The chart is back!
( •_•)
( •_•)>⌐■-■
(⌐■_■)

how

Removed feature flag for breakdown chart.
Added new model and factory for ReferralAggregates.
Chart now displays accurate data based on aggregates and total pledged amount. Yay percentages
SO MANY TESTS!

why

LOOK AT HER

Removed feature flag for breakdown chart.
Added new model and factory for ReferralAggregates.
Chart now displays accurate data based on aggregates and total pledged amount.
SO MANY TESTS!
@Scollaco Scollaco self-requested a review April 3, 2018 15:20
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Bring this chart back!

@eoji eoji merged commit 5235aa1 into master Apr 3, 2018
@eoji eoji deleted the the-chart-lives branch April 3, 2018 20:45
Rcureton pushed a commit that referenced this pull request Jul 31, 2018
✨ The chart is back!
Removed feature flag for breakdown chart.
Added new model and factory for ReferralAggregates.
Chart now displays accurate data based on aggregates and total pledged amount.
SO MANY TESTS!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants